[CBRD-24382] Fix segfault when target of CALL statement is not a stored procedure/function #3770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beyondykk9
approved these changes
Aug 17, 2022
ctshim
approved these changes
Aug 17, 2022
hyunikn
approved these changes
Aug 17, 2022
youngjinj
approved these changes
Aug 22, 2022
shparkcubrid
approved these changes
Aug 23, 2022
hgryoo
added a commit
to hgryoo/cubrid
that referenced
this pull request
Aug 31, 2022
…ed procedure/function (CUBRID#3770) http://jira.cubrid.org/browse/CBRD-24382 If CALL stmt is executed with a built-in function, a segmentation fault occurs. Referring to the SQL standard and the CUBRID manual, only a stored procedure can be called in the CALL statement, so an appropriate error should be returned. - In parsing, If generic_function is not a stored procedure/function, the parsed node type of call_stmt is not PT_METHOD_CALL. I've set an error in the case. - For the error message, MSGCAT_SEMANTIC_IS_NOT_A is already defined in the parser message catalog.
hgryoo
added a commit
to hgryoo/cubrid
that referenced
this pull request
Aug 31, 2022
…ed procedure/function (CUBRID#3770) http://jira.cubrid.org/browse/CBRD-24382 If CALL stmt is executed with a built-in function, a segmentation fault occurs. Referring to the SQL standard and the CUBRID manual, only a stored procedure can be called in the CALL statement, so an appropriate error should be returned. - In parsing, If generic_function is not a stored procedure/function, the parsed node type of call_stmt is not PT_METHOD_CALL. I've set an error in the case. - For the error message, MSGCAT_SEMANTIC_IS_NOT_A is already defined in the parser message catalog.
hgryoo
added a commit
to hgryoo/cubrid
that referenced
this pull request
Aug 31, 2022
…ed procedure/function (CUBRID#3770) http://jira.cubrid.org/browse/CBRD-24382 If CALL stmt is executed with a built-in function, a segmentation fault occurs. Referring to the SQL standard and the CUBRID manual, only a stored procedure can be called in the CALL statement, so an appropriate error should be returned. - In parsing, If generic_function is not a stored procedure/function, the parsed node type of call_stmt is not PT_METHOD_CALL. I've set an error in the case. - For the error message, MSGCAT_SEMANTIC_IS_NOT_A is already defined in the parser message catalog.
This was referenced Aug 31, 2022
mhoh3963
pushed a commit
that referenced
this pull request
Oct 13, 2022
…ed procedure/function (#3770) (#3785) http://jira.cubrid.org/browse/CBRD-24382 backport #3770
mhoh3963
pushed a commit
that referenced
this pull request
Oct 13, 2022
…ed procedure/function (#3770) (#3784) http://jira.cubrid.org/browse/CBRD-24382 backport #3770
mhoh3963
pushed a commit
that referenced
this pull request
Oct 13, 2022
…ed procedure/function (#3770) (#3783) http://jira.cubrid.org/browse/CBRD-24382 backport #3770
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jira.cubrid.org/browse/CBRD-24382
Motivation
If CALL stmt is executed with a built-in function, a segmentation fault occurs. Referring to the SQL standard and the CUBRID manual, only a stored procedure can be called in the CALL statement, so an appropriate error should be returned.
Implementation
generic_functionis not a stored procedure/function, the parsed node type ofcall_stmtis notPT_METHOD_CALL. I've set an error in the case.MSGCAT_SEMANTIC_IS_NOT_Ais already defined in the parser message catalog. I've used it.The error shows as follows.