-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CBRD-24516] replace the information which is printed in "show trace" from aggregate function optimization #3892
Conversation
The failed cases should be modified to reflect the changed TRACE text as following example:
|
src/optimizer/query_planner.c
Outdated
else | ||
{ | ||
fprintf (fp, "TABLE SCAN (%s)", class_name); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it is determined by the executor, it is not possible to output to the plan.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, however, the plan could be different from executing. Therefore, we need to print both of the plan and scan method in executing together in order to check whether the plan and scan method is same or different.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so. Inaccurate plan information will only confuse users.
http://jira.cubrid.org/browse/CBRD-24516
The trace information is printed from "show trace" command, however, the aggregate optimzation-related information is not printed.
The information including aggregate optimized should be shown from "show trace" in case of aggregate optimization enabled. The below is an sample information.
The modified code has 2 parts in "agg-optimized" setting.
optimizer
the plan's scan has "plan_un.scan.agg_optimized"
scanner
executor's scanner has "scan_stats.agg_optimized_scan"