Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CBRD-24573] Among the SERVER information, dbname and user can be input as a string type #3989

Merged
merged 2 commits into from
Dec 13, 2022

Conversation

ctshim
Copy link
Contributor

@ctshim ctshim commented Dec 6, 2022

http://jira.cubrid.org/browse/CBRD-24573

  • Modify to support both IDENTIFIER and string formats for DBNAME and USER entries.
    In the result of unloaddb, DBNAME and USER will be output in string format.

-- Identifier format

create server i1(host='localhost', port=33000, dbname=testdb, user=tester);
create server i2(host='localhost', port=33000, dbname="testdb", user="tester");
create server i3(host='localhost', port=33000, dbname=`testdb`, user=`tester`);
create server i4(host='localhost', port=33000, dbname=[testdb], user=[tester]);
create server i5(host='localhost', port=33000, dbname="79db", user=dba);
create server i6(host='localhost', port=33000, dbname="`79db`", user=dba);
create server i7(host='localhost', port=33000, dbname=`79db`, user=dba);
create server i8(host='localhost', port=33000, dbname=`"79"db`, user=dba);
create server i9(host='localhost', port=33000, dbname=[dqt"2"db], user=dba);
create server i10(host='localhost', port=33000, dbname=[sqt'2'db], user=dba);
create server i11(host='localhost', port=33000, dbname=[bqt`2`db], user=dba);

-- String format

create server s1(host='localhost', port=33000, dbname='79db', user=dba);
create server s2(host='localhost', port=33000, dbname='`79db`', user=dba);
create server s3(host='localhost', port=33000, dbname='"79"db', user=dba);
create server s4(host='localhost', port=33000, dbname='[dqt"2"db]', user=dba);
create server s5(host='localhost', port=33000, dbname='[sqt''2''db]', user=dba);
create server s6(host='localhost', port=33000, dbname='[bqt`''2''`db]', user=dba);
create server s7(host='localhost', port=33000, dbname='dqt"2"db', user=dba);
create server s8(host='localhost', port=33000, dbname='sqt''2''db', user=dba);
create server s9(host='localhost', port=33000, dbname='bqt`2`db', user=dba);
[cubrid@ctshim198 demodb]$ csql -S -udba -c "select link_name, db_name, user_name from db_server" demodb

=== <Result of SELECT Command in Line 1> ===

  link_name             db_name               user_name
==================================================================
  'i1'                  'testdb'              'tester'
  'i2'                  'testdb'              'tester'
  'i3'                  'testdb'              'tester'
  'i4'                  'testdb'              'tester'
  'i5'                  '79db'                'dba'
  'i6'                  '`79db`'              'dba'
  'i7'                  '79db'                'dba'
  'i8'                  '"79"db'              'dba'
  'i9'                  'dqt"2"db'            'dba'
  'i10'                 'sqt'2'db'            'dba'
  'i11'                 'bqt`2`db'            'dba'
  's1'                  '79db'                'dba'
  's2'                  '`79db`'              'dba'
  's3'                  '"79"db'              'dba'
  's4'                  '[dqt"2"db]'          'dba'
  's5'                  '[sqt'2'db]'          'dba'
  's6'                  '[bqt`'2'`db]'        'dba'
  's7'                  'dqt"2"db'            'dba'
  's8'                  'sqt'2'db'            'dba'
  's9'                  'bqt`2`db'            'dba'

20 rows selected. (0.044729 sec) Committed. (0.000173 sec)

[cubrid@ctshim198 demodb]$ cat demodb_schema | grep -A 4 "SERVER" | egrep "SERVER|DBNAME|USER"
CREATE SERVER [DBA].[i1] (
         DBNAME= 'testdb',
         USER= 'tester',
CREATE SERVER [DBA].[i2] (
         DBNAME= 'testdb',
         USER= 'tester',
CREATE SERVER [DBA].[i3] (
         DBNAME= 'testdb',
         USER= 'tester',
CREATE SERVER [DBA].[i4] (
         DBNAME= 'testdb',
         USER= 'tester',
CREATE SERVER [DBA].[i5] (
         DBNAME= '79db',
         USER= 'dba',
CREATE SERVER [DBA].[i6] (
         DBNAME= '`79db`',
         USER= 'dba',
CREATE SERVER [DBA].[i7] (
         DBNAME= '79db',
         USER= 'dba',
CREATE SERVER [DBA].[i8] (
         DBNAME= '"79"db',
         USER= 'dba',
CREATE SERVER [DBA].[i9] (
         DBNAME= 'dqt"2"db',
         USER= 'dba',
CREATE SERVER [DBA].[i10] (
         DBNAME= 'sqt''2''db',
         USER= 'dba',
CREATE SERVER [DBA].[i11] (
         DBNAME= 'bqt`2`db',
         USER= 'dba',
CREATE SERVER [DBA].[s1] (
         DBNAME= '79db',
         USER= 'dba',
CREATE SERVER [DBA].[s2] (
         DBNAME= '`79db`',
         USER= 'dba',
CREATE SERVER [DBA].[s3] (
         DBNAME= '"79"db',
         USER= 'dba',
CREATE SERVER [DBA].[s4] (
         DBNAME= '[dqt"2"db]',
         USER= 'dba',
CREATE SERVER [DBA].[s5] (
         DBNAME= '[sqt''2''db]',
         USER= 'dba',
CREATE SERVER [DBA].[s6] (
         DBNAME= '[bqt`''2''`db]',
         USER= 'dba',
CREATE SERVER [DBA].[s7] (
         DBNAME= 'dqt"2"db',
         USER= 'dba',
CREATE SERVER [DBA].[s8] (
         DBNAME= 'sqt''2''db',
         USER= 'dba',
CREATE SERVER [DBA].[s9] (
         DBNAME= 'bqt`2`db',
         USER= 'dba',
[cubrid@ctshim198 demodb]$

Comment on lines 1440 to 1445
1355 "%4$s"���� %3$d��° �ٿ�� %1$s "%2$s" �(��) �߸�� ����Դϴ�.�
1356 "%3$s ���� %2$d��° �ٿ�� ȣ��Ʈ �� "%1$s"�(��) �ʹ� ��ϴ�, ȣ��Ʈ ���� ���̴� 256�� ���� �۰ų� ���ƾ� �մϴ�.�
1357 "%3$s" ���� %2$d��° �ٿ�� ȣ��Ʈ �� "%1$s"�(��) �̹� �ֽ�ϴ�. �ϳ��� ȣ��Ʈ ���(��) �ߺ��Ǿ� �ٸ� IP �ּҸ� ���� �� ���ϴ�. �
1358 "%2$s" ���� %1$d��° �ٿ�� IP �ּҿ� ȣ��Ʈ �� �� �� �����ϰ� �ۼ��Ǿ�� �մϴ�.�
1359 cubrid_hosts.conf ���Ͽ�� "%1$s"�(��) ã� �� ���ϴ�.�
1360 user defined host�� ����ϴ� ���߿� ������ �߻��Ͽ���ϴ�.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like it is being erased by accident.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, thank you.

@ctshim ctshim merged commit beb0d5b into CUBRID:develop Dec 13, 2022
@ctshim ctshim deleted the CBRD-24573_SERVER_string_type branch December 13, 2022 23:24
ctshim added a commit to ctshim/cubrid that referenced this pull request Jan 16, 2023
…ut as a string type (CUBRID#3989)

http://jira.cubrid.org/browse/CBRD-24573

* [CBRD-24573] Among the SERVER information, dbname and user can be input as a string type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants