[CBRD-24563] [p11_2] Add RE2 regexp library as a backend for regular expression functions #4057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
http://jira.cubrid.org/browse/CBRD-24563 Implementation Move c++ implementation to string_regex_std.cpp Implement RE2 implementation in string_regex_re2.cpp Implement a common routine of regexp functions in string_regex.cpp C++ uses UTF-16 (wide string). But RE2 only supports UTF-8. Converting to UTF-8 to perform correctly for RE2 is required Implement functions that convert from/to string represented with a codeset (any codeset <-> utf-8) Refactor functions that convert from/to wstring. In C++ utf-8 string <-> wstring are supported. So the above functions are used in the functions. For RE2, Implement a function to split a string by position considering utf-8 codeset: re2_split_string () For RE2, Implement a function to get a distance between two positions in a string considering utf-8 codeset: re2_distance_utf8 () Add a system parameter (regexp_engine) to choose the regexp backend library.
CUBRID#4033) http://jira.cubrid.org/browse/CBRD-24563 PRM_KEYWORD is a better approach to validate the parameter value. I've changed regexp_engine to PRM_KEYWORD type and set lower and upper values.
beyondykk9
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jira.cubrid.org/browse/CBRD-24563
backport of #3997, #4033