Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CBRD-24638] The problem of the default value of column when altering the type of column. #4074

Merged
merged 16 commits into from
Mar 17, 2023

Conversation

beyondykk9
Copy link
Contributor

@beyondykk9 beyondykk9 commented Jan 26, 2023

http://jira.cubrid.org/browse/CBRD-24638

The problem is that the type of the column is changed, but the type of the default value is not changed. An error occurs while reading the default value in the format of the column type, not the stored type.

CREATE TABLE t_def (a bigint default 123456789012, b varchar(20));
ALTER TABLE t_def a a int;

Expected:
    ERROR: A domain conflict exists on attribute "a".

Actual:
    no error

@beyondykk9 beyondykk9 added this to the fig milestone Jan 26, 2023
@beyondykk9 beyondykk9 self-assigned this Jan 26, 2023
@mhoh3963 mhoh3963 merged commit 8a6ec84 into CUBRID:develop Mar 17, 2023
@beyondykk9 beyondykk9 deleted the CBRD-24638 branch March 17, 2023 06:52
beyondykk9 added a commit to beyondykk9/cubrid that referenced this pull request Mar 17, 2023
… the type of column. (CUBRID#4074)

* [CBRD-24638] The problem of the default value of column when altering the type of column.

* fix: old default value only

* Revert "fix: old default value only"

This reverts commit 21b1938.

* fix: old default value only

* fix-temp

* fix: check old default

* fix: default_expr

* fix: empty default

* fix: defatul value pointer

* fix: clone value

* add comment

* clear default_value
beyondykk9 added a commit to beyondykk9/cubrid that referenced this pull request Mar 21, 2023
… the type of column. (CUBRID#4074)

* [CBRD-24638] The problem of the default value of column when altering the type of column.

* fix: old default value only

* Revert "fix: old default value only"

This reverts commit 21b1938.

* fix: old default value only

* fix-temp

* fix: check old default

* fix: default_expr

* fix: empty default

* fix: defatul value pointer

* fix: clone value

* add comment

* clear default_value
beyondykk9 added a commit that referenced this pull request Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants