Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CBRD-24633] Delete owner information from schema, index, trigger, and object files of general users. #4136

Merged
merged 10 commits into from
Mar 3, 2023

Conversation

airnet73
Copy link
Contributor

@airnet73 airnet73 commented Feb 23, 2023

http://jira.cubrid.org/browse/CBRD-24633

Purpose
If there is owner information in the schema file, an error may occur when moving data from user_a to user_b. In this case, it is necessary to delete the owner information or change the onwer information in the schema file. In order to remove this inconvenience, it is necessary to delete the owner information.

Implementation

  • Change File
    Schema file, Index file, Trigger file, Object file

AS_IS

CREATE CLASS [user2].[test_t] REUSE_OID, COLLATE utf8_bin;
ALTER CLASS [user2].[test_t] ADD ATTRIBUTE
[col] integer NOT NULL;

CREATE PRIVATE SYNONYM [user1].[user1_s1] FOR [user2].[test_t];

TO_BE

CREATE CLASS [test_t] REUSE_OID, COLLATE utf8_bin;
ALTER CLASS [test_t] ADD ATTRIBUTE
[col] integer NOT NULL;

CREATE PRIVATE SYNONYM [user1_s1] FOR [user2].[test_t];

  • Add option
    --same-as-dba : If the login user is a member of the DBA group, extract the same schema file as the DBA.

Remarks
N/A

@airnet73 airnet73 self-assigned this Feb 23, 2023
@@ -1099,18 +1201,23 @@ extract_schema (extract_context & ctxt, print_output & schema_output_ctx)
}
}

if (ctxt.is_dba_user == false && ctxt.is_dba_group_member == false)
{
filter_user_classes (&ctxt.classes, ctxt.login_user);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we ctxt.login_user verify whether NULL or not?
I found ctxt.classes is checked. But ctxt.login_user is not found.

@@ -554,7 +554,8 @@ valid options:\n\
-S, --SA-mode stand-alone mode execution\n\
-C, --CS-mode client-server mode execution\n\
--datafile-per-class create a object file for each class; default: disabled\n\
--split-schema-files split schema information by object and generate each file; Default: generate one schema file with all objects\n
--split-schema-files split schema information by object and generate each file; Default: generate one schema file with all objects\n\
--same-as-dba If the login user is a member of the DBA group, extract the same schema file as the DBA.\n
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about:
--as-dba

if (text_print
(obj_out, NULL, 0, "%cid %s%s%s.%s%s%s %d\n", '%', PRINT_IDENTIFIER (owner_name),
PRINT_IDENTIFIER (class_name), i) != NO_ERROR)
if (ctxt.is_dba_user || ctxt.is_dba_group_member)
Copy link
Contributor

@kisoo-han kisoo-han Feb 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even I'm not sure it is effieient but I'll propose a solution to simplify, it up to you its just idea:

  1. define a function like:
char *
print_owner_name (char * owner_name, bool print_owner_name)
{
  char buf[DB_MAX_USER_LENGTH+4] = "";

  if (print_owner_name)
    {
      sprintf (buf, "%s%s%s%s", PRINT_IDENTIFIER (owner_name), ".")
    }

  return buf;
}
  1. Next re-write following if-else-block as follow:
if (text_print (obj_out, NULL, 0, "%cid %s%s%s%s %d\n", '%', print_owner_name (owner_name, ctxt.is_dba_user || ctxt.is_dba_group_member), PRINT_IDENTIFIER (class_name), ) != NO_ERROR)
  {
    status = 1;
    goto end;
  }

@airnet73 airnet73 closed this Mar 3, 2023
@airnet73 airnet73 reopened this Mar 3, 2023
@airnet73 airnet73 merged commit b461594 into CUBRID:develop Mar 3, 2023
hgryoo added a commit to hgryoo/cubrid that referenced this pull request Mar 16, 2023
commit 9584b21
Author: Hyung-Gyu Ryoo <hgryoo@cubrid.com>
Date:   Tue Mar 14 19:50:55 2023 +0900

    indent

commit 24833b4
Merge: 804144e 4cdc884
Author: Hyung-Gyu Ryoo <hgryoo@cubrid.com>
Date:   Tue Mar 14 19:50:41 2023 +0900

    Merge remote-tracking branch 'origin/CBRD-24694_session_ctx' into CBRD-24694_session_ctx

commit 804144e
Merge: 6907643 5714a4b
Author: Hyung-Gyu Ryoo <hgryoo@cubrid.com>
Date:   Tue Mar 14 19:49:17 2023 +0900

    Merge remote-tracking branch 'origin' into CBRD-24694_session_ctx

commit 4cdc884
Author: Hyung-Gyu Ryoo <hgryoo@cubrid.com>
Date:   Tue Mar 14 19:38:22 2023 +0900

    remove redundant change

commit f54b706
Author: Hyung-Gyu Ryoo <hgryoo@cubrid.com>
Date:   Tue Mar 14 18:57:22 2023 +0900

    trivial: slip, request_id should be passed

commit 7b7accb
Author: Hyung-Gyu Ryoo <hgryoo@cubrid.com>
Date:   Tue Mar 14 18:56:59 2023 +0900

    add EXPORT_IMPORT for functions in method_connection_java

commit 17abc6c
Author: Hyung-Gyu Ryoo <hgryoo@cubrid.com>
Date:   Tue Mar 14 17:09:57 2023 +0900

    fix windows build: add EXPORT_IMPORT for DLL exporting

commit 1b0b549
Author: Hyung-Gyu Ryoo <hgryoo@cubrid.com>
Date:   Tue Mar 14 17:09:23 2023 +0900

    rename to CUBRID_EXPORTING and added the definition to compile definition in cubridcs, cubridsa, libcubrid

commit 6907643
Author: Hyung-Gyu Ryoo <hgryoo@cubrid.com>
Date:   Fri Mar 10 16:13:21 2023 +0900

    fix copying next pointer in copy constructor and copy assignment operator

commit 404e1e8
Author: Hyung-Gyu Ryoo <hgryoo@cubrid.com>
Date:   Fri Mar 10 15:33:44 2023 +0900

    indent

commit 5c1bd67
Merge: 01c7572 4f89cc5
Author: Hyung-Gyu Ryoo <hgryoo@cubrid.com>
Date:   Fri Mar 10 15:31:48 2023 +0900

    Merge remote-tracking branch 'upstream/develop' into CBRD-24694_session_ctx

commit 4f89cc5
Author: Hyung-Gyu Ryoo <hgryoo@cubrid.com>
Date:   Fri Mar 10 14:53:50 2023 +0900

    [CBRD-24693] Segfault when Server-side JDBC's request is larger than 4096 (CUBRID#4165)

    http://jira.cubrid.org/browse/CBRD-24693

    The CUBRIDPacker can expand the output buffer internally, so the expanded buffer should be passed to the request() function.

commit 01c7572
Author: Hyung-Gyu Ryoo <hgryoo@cubrid.com>
Date:   Fri Mar 10 14:28:56 2023 +0900

    unpack groupId in PrepareArgs class

commit c63eb14
Author: Hyung-Gyu Ryoo <hgryoo@cubrid.com>
Date:   Fri Mar 10 14:27:59 2023 +0900

    refactor for C builtin

commit 8f29420
Author: Hyung-Gyu Ryoo <hgryoo@cubrid.com>
Date:   Fri Mar 10 14:27:05 2023 +0900

    add copy constructor for METHOD_SIG, handle METHOD_TYPE_NONE

commit aeea57a
Author: ctshim <78332782+ctshim@users.noreply.github.com>
Date:   Fri Mar 10 08:31:12 2023 +0900

    [CBRD-24587] Core dumped in do_alter_server (CUBRID#4167)

    http://jira.cubrid.org/browse/CBRD-24587

    * fix core dumped in do_alter_server after  [CBRD-24573]

commit 46c1660
Author: Hyung-Gyu Ryoo <hgryoo@cubrid.com>
Date:   Thu Mar 9 21:35:37 2023 +0900

    refactor: add get_next_java_header() to return header with incremented request id

commit 00bea08
Author: Hyung-Gyu Ryoo <hgryoo@cubrid.com>
Date:   Thu Mar 9 21:34:47 2023 +0900

    revise comment

commit 11cf5bd
Author: Hyung-Gyu Ryoo <hgryoo@cubrid.com>
Date:   Thu Mar 9 14:37:29 2023 +0900

    add ensureSpace() in the packing bytebuffer function

commit 447a726
Author: Hyung-Gyu Ryoo <hgryoo@cubrid.com>
Date:   Thu Mar 9 14:31:55 2023 +0900

    refactor

commit 32fcab0
Author: Hyung-Gyu Ryoo <hgryoo@cubrid.com>
Date:   Thu Mar 9 14:29:18 2023 +0900

    refactor protocol related: header, request_id. add getters

commit d352c15
Author: Hyung-Gyu Ryoo <hgryoo@cubrid.com>
Date:   Wed Mar 8 14:34:34 2023 +0900

    [CBRD-24689] Upgrade junixsocket library to the 2.6.2 version (CUBRID#4163)

    http://jira.cubrid.org/browse/CBRD-24689

    Junixsocket 2.4.0 version has the file descriptor leak bug. To fix the bug, The junixsocket's version should be upgraded to the 2.6.2 version (latest).

commit d10dc97
Author: airnet73 <61675061+airnet73@users.noreply.github.com>
Date:   Wed Mar 8 10:12:08 2023 +0900

    [CBRD-24542] Disable schema loading in loaddb online (CUBRID#4156)

    http://jira.cubrid.org/browse/CBRD-24542

    When running online mode loaddb (cubrid loaddb -C) in HA environment DDL replication does not occur to slave nodes.
    For this reason, the online mode loaddb is modified so that only object loading is possible.

commit 83ddb0e
Author: airnet73 <61675061+airnet73@users.noreply.github.com>
Date:   Wed Mar 8 10:10:57 2023 +0900

    [CBRD-24688] Exception handling for users without class data (CUBRID#4164)

    http://jira.cubrid.org/browse/CBRD-24688

    An issue occurred because error handling was not performed for users who did not have class data.
    If there is no class data, an error message is displayed.

commit 1d0e25b
Author: Byungwook Kim <bwkim@cubrid.com>
Date:   Wed Mar 8 09:39:15 2023 +0900

    [CBRD-24654] When getting a NUMERIC type value, if the value after the decimal point is 0, it should be improved so that the trailing 0's are not passed. (CUBRID#4096)

    http://jira.cubrid.org/browse/CBRD-24654

commit c03d08a
Author: Hyung-Gyu Ryoo <hgryoo@cubrid.com>
Date:   Tue Mar 7 20:47:20 2023 +0900

    remove redundant ExecuteThreadStatus and related functions

commit bd2bfa3
Author: Hyung-Gyu Ryoo <hgryoo@cubrid.com>
Date:   Tue Mar 7 20:35:55 2023 +0900

    implement getClientInfo

commit acaf157
Author: Hyung-Gyu Ryoo <hgryoo@cubrid.com>
Date:   Tue Mar 7 20:25:36 2023 +0900

    add Context and ContextManager, refactor communication and routine for the context

commit 1961af9
Author: Hyung-Gyu Ryoo <hgryoo@cubrid.com>
Date:   Tue Mar 7 05:55:58 2023 +0900

    align for payload

commit dfcdeb6
Merge: 1861454 acb0f0e
Author: Hyung-Gyu Ryoo <hgryoo@cubrid.com>
Date:   Mon Mar 6 23:41:06 2023 +0900

    Merge remote-tracking branch 'upstream/develop' into lab_context_manager

commit 1861454
Author: Hyung-Gyu Ryoo <hgryoo@cubrid.com>
Date:   Mon Mar 6 23:38:33 2023 +0900

    draft

commit acb0f0e
Author: Hyung-Gyu Ryoo <hgryoo@cubrid.com>
Date:   Mon Mar 6 15:28:05 2023 +0900

    [CBRD-24682] Fix error handling problem caused by CBRD-24585 (CUBRID#4147)

    http://jira.cubrid.org/browse/CBRD-24682

    - Set error contexts in prepare() and execute() functions correctly.
    - In execute(), setting error should be done again after ER_QPROC_INVALID_XASLNODE is handled.
    - Remove redundant setting error context after db_execute_and_keep_statement ().

commit 08ac06f
Author: airnet73 <61675061+airnet73@users.noreply.github.com>
Date:   Mon Mar 6 13:24:12 2023 +0900

    [CBRD-24623] Class members initialization (CUBRID#4160)

    http://jira.cubrid.org/browse/CBRD-24623

    Error in initializing member variable of class, warning occurs when building

commit 0559d05
Author: Yeoun <yahong@student.42seoul.kr>
Date:   Mon Mar 6 13:20:03 2023 +0900

    [CBRD-24672] Remove a unnessasary condition in btree_verify_subtree. (CUBRID#4131)

    http://jira.cubrid.org/browse/CBRD-24672

    Purpose
    Remove the duplicate condition in function, btree_verify_subtree.

commit b4de234
Author: Yeoun <yahong@student.42seoul.kr>
Date:   Mon Mar 6 13:19:34 2023 +0900

    [CBRD-24671] Disable deprecated functions in lock manager. (CUBRID#4129)

    http://jira.cubrid.org/browse/CBRD-24671

    Purpose

    Cover a deprecated function, lock_remove_object_lock with macro ENABLE_UNUSED_FUNCTION, not to be reflected in compilatoin.

commit 129a0da
Author: Yeoun <yahong@student.42seoul.kr>
Date:   Mon Mar 6 13:19:03 2023 +0900

    [CBRD-24670] Fix simple typo in btree_find_next_index_record. (CUBRID#4128)

    http://jira.cubrid.org/browse/CBRD-24670

    Purpose
    Fix some typos of comment.

commit 001d9f0
Author: airnet73 <61675061+airnet73@users.noreply.github.com>
Date:   Mon Mar 6 11:35:39 2023 +0900

    [CBRD-24634] Delete methods that require privileges from the general user's schema file (CUBRID#4155)

    http://jira.cubrid.org/browse/CBRD-24634

    In the schema file, both METHODs that require privileges and METHODs that do not require privileges are used.
    In the case of a general user, an error occurs when using METHOD that requires authority.
    The general user's schema file must be created without METHOD requiring privileges.

commit b73d1cb
Author: airnet73 <61675061+airnet73@users.noreply.github.com>
Date:   Mon Mar 6 11:34:50 2023 +0900

    [CBRD-24679] auto_commit log error in sql log (CUBRID#4159)

    http://jira.cubrid.org/browse/CBRD-24679

    Auto-commit is performed on the server, but in the broker's sql log, it is written that it was performed on the client.
    Conversely, auto-commit is performed on the client, but the broker's sql log is written as being performed on the server.

commit 3f06d44
Author: Hyung-Gyu Ryoo <hgryoo@cubrid.com>
Date:   Fri Mar 3 19:43:10 2023 +0900

    refactor method_connection, add session_id in header

commit 7463d4a
Author: Hyung-Gyu Ryoo <hgryoo@cubrid.com>
Date:   Fri Mar 3 17:16:33 2023 +0900

    [CBRD-24662] Add a LoggingThread to access javasp's log file by only one thread (CUBRID#4137)

    http://jira.cubrid.org/browse/CBRD-24662

    Java FileHandler creates a new file with an increasing number when there exist conflicts to a file. Because of this, If an exception occurs very quickly by many threads in the Java SP server, Many log files are generated by the FileHandler's behavior.
    To avoid this behavior, This PR implements the LoggingThread to access a log file with a single thread. Other threads will put their exception into LinkedBlockingQueue. And the LoggingThread will take the log string of exception without conflict.

commit b461594
Author: airnet73 <61675061+airnet73@users.noreply.github.com>
Date:   Fri Mar 3 11:04:21 2023 +0900

    [CBRD-24633] Delete owner information from schema, index, trigger, and object files of general users. (CUBRID#4136)

    http://jira.cubrid.org/browse/CBRD-24633

    If there is owner information in the schema file, an error may occur when moving data from user_a to user_b. In this case, it is necessary to delete the owner information or change the onwer information in the schema file. In order to remove this inconvenience, it is necessary to delete the owner information.

commit d41e0b9
Author: Dongmin Kim <49967405+Srltas@users.noreply.github.com>
Date:   Thu Mar 2 13:59:24 2023 +0900

    [CBRD-24614] Fix csql msg file caused by CBRD-24614 (CUBRID#4151)

    http://jira.cubrid.org/browse/CBRD-24614

    * ko_KR.euckr csql.msg change file encoding from utf-8 to euc-kr
    * fix ro_RO.utf8 csql.msg file

commit ce7937a
Author: SE park <shpark@cubrid.com>
Date:   Mon Feb 27 13:12:49 2023 +0900

    [CBRD-24668] Problem that predicate evaluation order is not kept after view merging and push-predicate. (CUBRID#4124)

    http://jira.cubrid.org/browse/CBRD-24668

    1. Add PRED_ORDER to predicates. (pt_expr_info, qo_term)
    2. Increases the pred_order for predicates that must be evaluated first during push-predicate and view-merge. (pt_set_pred_order() )
    3. Add logic to sort based on pred_order. (qo_discover_edges() )
    4. Since the sorting routine in the existing XASL gerneration is redundant, delete it and keep the sorting related routine only in the optimizer. (make_pred_from_bitset() )

commit aadd159
Author: airnet73 <61675061+airnet73@users.noreply.github.com>
Date:   Mon Feb 27 11:14:05 2023 +0900

    [CBRD-24624] Add ability to load multiple schema files from loaddb (CUBRID#4120)

    http://jira.cubrid.org/browse/CBRD-24624

    You can load schema files that are separated into several in loaddb one by one, but if you load them one by one, errors may occur because the order of loading is incorrect.
    To reduce these inconveniences and errors, a file in which the loading order is written is provided, and schema files can be loaded in order through this file.

commit 0b8bcd4
Author: Dongmin Kim <49967405+Srltas@users.noreply.github.com>
Date:   Thu Feb 23 13:04:27 2023 +0900

    [CBRD-24614] Integrate SQL formatter to ‘edit’ csql session command (CUBRID#4097)

    http://jira.cubrid.org/browse/CBRD-24614

    Purpose
    Want to simplify QUERY tuning and SQL analysis in console without SQL tools and Editing tools.
    SQL formatter is available through the ';edit' csql session command option 'format / fmt'.

    Implementation
    N/A

    Remarks
    N/A

commit 14d7e06
Author: airnet73 <61675061+airnet73@users.noreply.github.com>
Date:   Tue Feb 21 15:24:13 2023 +0900

    [CBRD-24622] Create 10 SCHEMA Files for each object type. (CUBRID#4088)

    http://jira.cubrid.org/browse/CBRD-24623

    To move data by object without editing schema file, when creating schema file, it is necessary to create by object as follows.
    Creates 10 schema files using options, and stores the file list in xxx_schema_info.

commit d38434c
Author: Kisoo Han <kisoo-han@cubrid.com>
Date:   Tue Feb 21 10:32:32 2023 +0900

    [CBRD-24667] Fix error for backup_dest_path in ha_make_slavedb.sh (CUBRID#4122)

    Fix error for backup_dest_path in ha_make_slavedb.sh

commit 5abd400
Author: Joo Youngjin <68979537+youngjinj@users.noreply.github.com>
Date:   Mon Feb 20 17:27:57 2023 +0900

    [CBRD-24660] Change small functions that are frequently called in index scans to INLINE. (CUBRID#4109)

    http://jira.cubrid.org/browse/CBRD-24660

    Change small functions that are frequently called in index scans to INLINE.
    - btree_clear_key_value
    - btree_init_temp_key_value
    - pr_is_set_type (with pr_is_string_type, pr_is_prefix_key_type)
    - scan_init_filter_info

commit 84d8194
Author: SE park <shpark@cubrid.com>
Date:   Mon Feb 20 15:22:23 2023 +0900

    [CBRD-24518] Revert  - The problem that the number of objects in statistics is not updated when data is deleted. (CUBRID#4123)

    http://jira.cubrid.org/browse/CBRD-24518
    Reverts CUBRID#3895

    This issue is excluded from 11.3, in order to proceed with [CBRD-24409] Add Non-accumulative selectivity of columns.

commit f6a4b96
Author: SE park <shpark@cubrid.com>
Date:   Wed Feb 15 18:50:23 2023 +0900

    [CBRD-24559] Revert - Use the number of unique index keys as number of objects for statistics. (CUBRID#4110)

    Revert "[CBRD-24559] Use the number of unique index keys as number of objects for statistics. (CUBRID#3947)"

    This reverts commit e6cdfce.

commit e56ae97
Author: SE park <shpark@cubrid.com>
Date:   Wed Feb 15 18:35:34 2023 +0900

    [CBRD-24502] The problem of updating statistical information when performing DDL. (CUBRID#4111)

    http://jira.cubrid.org/browse/CBRD-24502
    CUBRID#3884

    It is modified so that statistics are not updated during DDL. DDL includes index creation and drop, such as 'CREATE INDEX'.
    The optimizer sets the default selectivity for new statistics that are not updated.

commit 4955c8e
Author: joonmin83 <hornetmj@cubrid.com>
Date:   Tue Feb 14 17:27:10 2023 +0900

    [CBRD-24630] The stop command of cubrid hb applylogdb with -h option does not work correctly when the build is generated in the QA environment, release mode and devtoolset-9 (CUBRID#4107)

    http://jira.cubrid.org/browse/CBRD-24630

commit b04abd5
Author: Kisoo Han <kisoo-han@cubrid.com>
Date:   Tue Feb 14 14:21:08 2023 +0900

    [CBRD-24389] Fix error for ADMIN_LOG_FILE directory creation (CUBRID#4102)

    Fix error for ADMIN_LOG_FILE directory creation

commit c1db9f8
Author: Kisoo Han <kisoo-han@cubrid.com>
Date:   Tue Feb 14 12:40:42 2023 +0900

    [CBRD-24659] Add linux style absolute path as windows style also (CUBRID#4106)

    change windows absolute path to /abc.txt, c:/abc.txt, c:\abc.txt style

commit 679eca4
Author: ctshim <78332782+ctshim@users.noreply.github.com>
Date:   Thu Feb 9 12:45:18 2023 +0900

    [CBRD-24571] assert() occurs when using DELETE/UPDATE including DBLINK (CUBRID#3978)

    http://jira.cubrid.org/browse/CBRD-24571

    * change the call location for pt_resolve_dblink_server_name()

commit 2c87b38
Author: Kisoo Han <kisoo-han@cubrid.com>
Date:   Thu Feb 9 09:42:19 2023 +0900

    [CBRD-24389] Fix for creating DIR for ADMIN_LOG_FILE, in Windows (CUBRID#4095)

    fix the problem that the directory for ADMIN_LOG_FILE was not created in Windows

commit f2856af
Author: SE park <shpark@cubrid.com>
Date:   Wed Feb 8 15:45:44 2023 +0900

    [CBRD-24652] The problem performing hash list scan when VOBJECT is included in predicates. (CUBRID#4091)

    http://jira.cubrid.org/browse/CBRD-24652

    Add check for vobj type, which can not be hash-scan.

commit a2ccab8
Author: SE park <shpark@cubrid.com>
Date:   Wed Feb 8 14:55:21 2023 +0900

    [CBRD-24651] Problem that need_count_only optimization is applied when query has after_join predicates (CUBRID#4089)

    http://jira.cubrid.org/browse/CBRD-24651

    The need_count_optimization is only available when there are no data filters. I add after_join predicate check.

commit 0db1d7d
Author: joonmin83 <hornetmj@cubrid.com>
Date:   Wed Feb 8 14:03:37 2023 +0900

    [CBRD-24630] The stop command of cubrid hb (applylogdb/repl) does not work correctly when the build is generated in the QA environment, release mode and devtoolset-9 (CUBRID#4092)

    http://jira.cubrid.org/browse/CBRD-24630

    Purpose

    when the build is created in the QA env, release mode and devtoolset-9, the stop command of cubrid hb (applylogdb or replication) doesn't work correctly
    the reason is not clear. But the problem is related to the strcmp function. The following code block is in the process_is_registered_proc(). And the if condition checks the response from cub_master in order to check the copylogdb or applylogdb is alive
    if (size > 0 && strcmp (reply_buffer, HA_REQUEST_SUCCESS) == 0)
    the problem is that the strcmp() returns a positive value even if values of arguments are equal
    when I try to dump values of arguments as hexa, they have same values with null termination
    when I try to compare them using memcmp(), strcmp()(again), they return 0
    when I try to check the length of them using strlen(), they return 1 (it means values are terminated with null)
    now, I don't have any options to handle this problem. But when I change the strcmp() to strncmp(), the problem is disapeared. So I apply this fix for the regression test temparaly(or permenantly if there are no solution)
    Implementation

    strcmp() -> strncmp()
    Remarks

    the problem is occurred after changing devtoolset-8 to devtoolset-9

commit ffb8a38
Author: Joo Youngjin <68979537+youngjinj@users.noreply.github.com>
Date:   Tue Feb 7 14:56:21 2023 +0900

    [CBRD-24632] Change data put, get and support functions using OR_BUF in object_representation.c to inline functions (CUBRID#4066)

    http://jira.cubrid.org/browse/CBRD-24632

    Change data put, get and support functions using OR_BUF in object_representation.c to inline functions

commit 08f2464
Author: Joo Youngjin <68979537+youngjinj@users.noreply.github.com>
Date:   Tue Feb 7 14:55:56 2023 +0900

    [CBRD-24586] Members of the DBA group must be able to see all objects in the system view. (CUBRID#4003)

    http://jira.cubrid.org/browse/CBRD-24586

    The where clause of the system view is changed as below.
    - AS-IS
       ```
       CURRENT_USER = 'DBA'
       ```
    - TO-BE
       ```
       {'DBA'} SUBSETEQ (
           SELECT
             SET {CURRENT_USER} + COALESCE (SUM (SET {[t].[g].[name]}), SET {})
           FROM
             [db_user] AS [u], TABLE ([u].[groups]) AS [t] ([g])
           WHERE
             [u].[name] = CURRENT_USER
         )
       ```

commit 39c427c
Author: Yeoun <yahong@student.42seoul.kr>
Date:   Tue Feb 7 11:01:16 2023 +0900

    [CBRD-24640] Specify the upper and lower bounds of the tde_default_algorithm parameter. (CUBRID#4083)

    http://jira.cubrid.org/browse/CBRD-24640

    Purpose

    The limits have been added to prevent the value changes of tde_default_algorithm parameter to a value other than TDE_ALGORITHM (TDE_ALGORITHM_NONE, TDE_ALGORITHM_AES, TDE_ALGORITHM_ARIA).
    Below is an enumeration of TDE_ALGORITHM.

commit d93f4b1
Author: Joo Youngjin <68979537+youngjinj@users.noreply.github.com>
Date:   Fri Feb 3 17:15:30 2023 +0900

    [CBRD-24252] Removes the table of the primary key from the join with the table with the foreign key referencing it. (CUBRID#3838)

    http://jira.cubrid.org/browse/CBRD-24252

    A table with a primary key is removed from a join with a table with a foreign key that references the primary key. There must be no references to the table to be removed other than join predicates. This is because the relationship between a primary key and a foreign key replaces a data filter of a join. If a table with a primary key is removed, a predicate for IS NOT NULL may be added, as it cannot filter on NULL.

commit 3d20edf
Author: SE park <shpark@cubrid.com>
Date:   Fri Feb 3 14:23:32 2023 +0900

    [CBRD-24645] When order-by of subquery is copied to main query during view merging, rownum of main query is displayed incorrectly (CUBRID#4080)

    http://jira.cubrid.org/browse/CBRD-24645

    When 'ORDER BY' is copied to the main query during view-merging, I fix so that 'ROWNUM' of the select list of the main query is replaced with 'ORDERBY_NUM'.

commit 6ba7945
Author: Kisoo Han <kisoo-han@cubrid.com>
Date:   Thu Feb 2 13:02:27 2023 +0900

    [CBRD-24644] 64bit statdump output for CMS the clients (CUBRID#4084)

    64bit statdump output for CMS clients

commit dd1ab3c
Author: airnet73 <61675061+airnet73@users.noreply.github.com>
Date:   Wed Feb 1 20:32:24 2023 +0900

    [CBRD-24648] Change unixODBC source download URL (CUBRID#4085)

    http://jira.cubrid.org/browse/CBRD-24648

    I downloaded and used it from the www.unixODBC.org site, but a site failure occurred, so I changed the URL.

commit 9f71e8f
Author: eido5 <75719942+eido5@users.noreply.github.com>
Date:   Mon Jan 30 15:00:45 2023 +0900

    [CBRD-24599] Add new csql session command 'SingleLine' (CUBRID#4065)

    http://jira.cubrid.org/browse/CBRD-24599

    -Purpose

    In csql, there are two modes to handle sql statements.

    * single line (with semicolon, handling sql each line)
    *  --no-single-line (handling the sql at once with ;xr or ;r session command)
    To csql change mode, we must quit the csql and restart with '--no-single-line' option or not.
    So, we need to switch the both modes while csql is working. This session command will help user use csql more convenient.

    -Implementation

    Add new csql session command.

    -Remarks

    N/A

commit e0612fe
Author: sjkimxxx <42533491+sjkimxxx@users.noreply.github.com>
Date:   Mon Jan 30 14:39:52 2023 +0900

    [CBRD-24629] Core block size 1(4K) (CUBRID#4077)

    * Core block size 1(4K)

    * [empty] this is a empty commit

commit 351bbb2
Author: Hyung-Gyu Ryoo <hgryoo@cubrid.com>
Date:   Fri Jan 27 17:59:18 2023 +0900

    [CBRD-24642] Add checking JVM is loaded in SA_MODE not to return error (CUBRID#4075)

    http://jira.cubrid.org/browse/CBRD-24642

    add checking jvm is loaded on SA-MODE

commit a6e638b
Author: Hyung-Gyu Ryoo <hgryoo@cubrid.com>
Date:   Fri Jan 20 15:00:26 2023 +0900

    [CBRD-24627] Add LZ4 and RE2 to EP_TARGETS in CMake (CUBRID#4067)

    http://jira.cubrid.org/browse/CBRD-24627

commit 08e2baf
Author: Byungwook Kim <bwkim@cubrid.com>
Date:   Fri Jan 20 08:37:43 2023 +0900

    [CBRD-24615] Result value error when using query cache in partition table (CUBRID#4028)

    http://jira.cubrid.org/browse/CBRD-24615

commit 53d0efe
Author: Hyung-Gyu Ryoo <hgryoo@cubrid.com>
Date:   Thu Jan 19 17:16:49 2023 +0900

    [CBRD-24631] Fix segfault when an error occurs with return_null_on_function_errors is on (CUBRID#4062)

    http://jira.cubrid.org/browse/CBRD-24631

    During error handling, a segfault occurs because the RLIKE_TERM pointer refers to an incorrect address by comp_regex = NULL; . It occurs only in the case of return_null_on_function_errors is on.

commit 22bbb0b
Author: Joo Youngjin <68979537+youngjinj@users.noreply.github.com>
Date:   Thu Jan 19 14:42:43 2023 +0900

    [CBRD-24609] When loading object files online, system class/vclass does not use the schema name of the current session. (CUBRID#4063)

    http://jira.cubrid.org/browse/CBRD-24609

    When loading object files online, system class/vclass does not use the schema name of the current session.

commit 5714a4b
Merge: 6cce6a6 b80bc35
Author: Hyung-Gyu Ryoo <hgryoo@cubrid.com>
Date:   Tue Dec 17 09:30:05 2019 +0900

    Merge remote-tracking branch 'upstream/develop' into develop

commit 6cce6a6
Merge: 90f1730 d6399ad
Author: hgryoo <hgryoo@cubrid.com>
Date:   Mon Nov 12 10:35:21 2018 +0900

    Merge branch 'develop' of https://github.com/CUBRID/cubrid into develop

commit 90f1730
Merge: e7d6074 613b511
Author: hgryoo <hgryoo@cubrid.com>
Date:   Tue Nov 6 15:55:30 2018 +0900

    Merge remote-tracking branch 'upstream/develop' into develop

commit e7d6074
Merge: 4eaca35 ff55dbe
Author: hgryoo <hgryoo@cubrid.com>
Date:   Mon Nov 5 14:37:39 2018 +0900

    Merge remote-tracking branch 'upstream/develop' into develop

commit 4eaca35
Merge: c614001 c95266d
Author: hgryoo <hgryoo@cubrid.com>
Date:   Tue Oct 30 09:54:59 2018 +0900

    Merge branch 'develop' of http://github.com/cubrid/cubrid into develop

commit c614001
Author: Hyung-Gyu Ryoo <hyunggyu.ryoo@gmail.com>
Date:   Tue Sep 18 17:50:50 2018 +0900

    [APIS-778]JDBC CUBRIDStatement.setFetchSize(int rows) throw wrong illegalArgumentException when rows value is zero
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants