[CBRD-24516] multi-aggregate-optimize: replace the information which is printed in "show trace" from aggregate function optimization #4424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is printed in "show trace" from aggregate function optimization
hgryoo
approved these changes
Jun 14, 2023
hyunikn
reviewed
Jun 19, 2023
| @@ -302,6 +302,13 @@ struct scan_pos | |||
| QFILE_TUPLE_POSITION ls_tplpos; /* List file index scan position */ | |||
| }; /* Scan position structure */ | |||
|
|
|||
| typedef struct scan_agl SCAN_AGL; | |||
There was a problem hiding this comment.
[Q] Does AGL stands for Aggregation List?
There was a problem hiding this comment.
agl stands for Aggregation Lookup.
src/query/query_executor.c
Outdated
| free (p->s_id.scan_stats.agg_index_name); | ||
| SCAN_AGL *agl; | ||
|
|
||
| for (agl = p->s_id.scan_stats.agl; agl; agl = agl->next) |
There was a problem hiding this comment.
agl->next : accessing next of the freed agl seems unsafe.
There was a problem hiding this comment.
Ok, I modified at the next commit.
hyunikn
approved these changes
Jun 20, 2023
ctshim
reviewed
Jun 20, 2023
| agl = (SCAN_AGL *) malloc (sizeof (SCAN_AGL)); | ||
| if (agl == NULL) | ||
| { | ||
| return ER_FAILED; |
There was a problem hiding this comment.
free (agg_index_name);
return ER_FAILED;
ctshim
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jira.cubrid.org/browse/CBRD-24516
SHOW TRACE is will be shown as like below: