Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CBRD-25086] Add words for the user convenience in user hosts. #4839

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

eido5
Copy link
Contributor

@eido5 eido5 commented Dec 14, 2023

http://jira.cubrid.org/browse/CBRD-25086

Description

For the user convenience, cubrid.msg and cubrid_hosts.conf should be fixed related with user hosts.

AS-IS

Cannot find ("%1$s") in "%2$s". Please check permissions of the file or if there is the hostname.
[Default content of cubrid_host.conf]
127.0.0.1 localhost

TO-BE

Cannot find hostname ("%1$s") in "%2$s". Please check permissions of the file or if there is the hostname.
[Default content of cubrid_host.conf]
127.0.0.1 localhost
0.0.0.0 your_hostname

@eido5 eido5 requested a review from kisoo-han December 14, 2023 10:08
@eido5
Copy link
Contributor Author

eido5 commented Dec 21, 2023

@kisoo-han
Could we close this PR?
Because I think at #4844, discussion will be lasted including QA's fix notice and so on.
Could you review the PR at #4844 again? Actually this and that PR are totally same.

@kisoo-han
Copy link
Contributor

@eido5 ,
QA team told me that they will fix CI problem by next week.
So, I think we don't need to close this PR and wait until they fix the problem.
After that, we can re-run CI again and expect to pass CI. So, please wait.

@eido5
Copy link
Contributor Author

eido5 commented Dec 21, 2023

@kisoo-han
I see. Thank you.

@sjkimxxx
Copy link
Contributor

@eido5
All checks have passed

@eido5
Copy link
Contributor Author

eido5 commented Dec 28, 2023

@sjkimxxx
I checked it.
Thank you!

@eido5 eido5 merged commit 4ea1c76 into CUBRID:release/11.3 Jan 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants