[CBRD-25216] Check if there is enough buffer to store the user-specified name (#4946) #4955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ied name (CUBRID#4946) http://jira.cubrid.org/browse/CBRD-25216 We found that the buffer of the pt_get_name_without_current_user_name function may be insufficient to copy the user-specified name. Also, we found that if the name of the auto-increment serial exceeds 254 bytes, it is truncated to 254 bytes when the owner of the table changes. In debug mode, if the table name exceeds 222 bytes, an assertion occurs in sm_user_specified_name. To prevent this, there are the following changes: 1. Copy only the qualifier name from the user-specified name in the pt_get_name_without_current_user_name function. 2. Add sm_user_specified_name_for_serial function. 3. Check if there is enough buffer in sm_user_specified_name and sm_qualifier_name functions. 4. Do not truncate the length of the new serial name to 254 bytes in the au_change_serial_owner function. 5. Add a safe guard to sm_user_specified_name and sm_user_specified_name_for_serial.
shparkcubrid
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jira.cubrid.org/browse/CBRD-25216
backport #4946