[CBRD-25298] trim class and method names of the target method #5104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hod by reflection (2) use familiar type names of parameter types in the error messages of NoSuchMethod
hgryoo
reviewed
Apr 9, 2024
Comment on lines
218
to
221
| List<String> argTypeNameList = | ||
| Arrays.stream(argsTypes) | ||
| .map(cl -> cl.getTypeName()) | ||
| .collect(Collectors.toList()); |
There was a problem hiding this comment.
trivial: please note that target JDK version of CUBRID 10.2 and 11.0 is 6. Arrays.stream() doesn't support on JDK 6. some additional works needs.
hgryoo
approved these changes
Apr 9, 2024
ctshim
approved these changes
Apr 11, 2024
hyunikn
added a commit
to hyunikn/cubrid
that referenced
this pull request
Apr 11, 2024
…#5104) * (1) trim the class name and the method name before search for the method by reflection (2) use familiar type names of parameter types in the error messages of NoSuchMethod * rewrite code without the Java 8 Stream feature
hyunikn
added a commit
to hyunikn/cubrid
that referenced
this pull request
Apr 11, 2024
…#5104) * (1) trim the class name and the method name before search for the method by reflection (2) use familiar type names of parameter types in the error messages of NoSuchMethod * rewrite code without the Java 8 Stream feature
hyunikn
added a commit
to hyunikn/cubrid
that referenced
this pull request
Apr 11, 2024
…#5104) * (1) trim the class name and the method name before search for the method by reflection (2) use familiar type names of parameter types in the error messages of NoSuchMethod * rewrite code without the Java 8 Stream feature
hyunikn
added a commit
that referenced
this pull request
Apr 12, 2024
* [CBRD-25298] trim class and method names of the target method (#5104) . trim the class name and the method name before search for the method by reflection . use familiar type names of parameter types in the error messages of NoSuchMethod
hyunikn
added a commit
that referenced
this pull request
May 7, 2024
* [CBRD-25298] trim class and method names of the target method (#5104) * (1) trim the class name and the method name before search for the method by reflection (2) use familiar type names of parameter types in the error messages of NoSuchMethod * rewrite code without the Java 8 Stream feature * minor: removed an unused line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jira.cubrid.org/browse/CBRD-25298
. trim the class name and the method name before search for the method by reflection
. use familiar type names of parameter types in the error messages of NoSuchMethod