-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typo in DAE Scalar Descriptions #517
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lines 313 to 321 in f955c3e
self._array_and_counter = { | |
'f': 'n', # differential equation RHS | |
'x': 'n', # differential variables | |
'g': 'm', # algebraic equation residual | |
'y': 'm', # algebraic variables | |
'z': 'o', # limiter flags | |
'h': 'p', # RHS of external states | |
'i': 'q', # RHS of external algebraic variables | |
} |
Given this code, I feel m is The number of algebraic variables/equations, and n is The number of state variables/equations.
Besides, would you mind changing the target branch from CURENT:master
to CURENT:develop
? This helps us follow a better version control manner.
Yes, you are correct. I will change it, thank you! |
Typo in DAE Scalar Description table.