Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in DAE Scalar Descriptions #517

Merged
merged 7 commits into from
Mar 8, 2024
Merged

Conversation

weigao-123
Copy link
Contributor

Typo in DAE Scalar Description table.

Copy link
Member

@jinningwang jinningwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self._array_and_counter = {
'f': 'n', # differential equation RHS
'x': 'n', # differential variables
'g': 'm', # algebraic equation residual
'y': 'm', # algebraic variables
'z': 'o', # limiter flags
'h': 'p', # RHS of external states
'i': 'q', # RHS of external algebraic variables
}

Given this code, I feel m is The number of algebraic variables/equations, and n is The number of state variables/equations.

Besides, would you mind changing the target branch from CURENT:master to CURENT:develop? This helps us follow a better version control manner.

@weigao-123
Copy link
Contributor Author

Yes, you are correct. I will change it, thank you!

@weigao-123 weigao-123 changed the base branch from master to develop March 7, 2024 22:43
@jinningwang jinningwang merged commit b5df676 into CURENT:develop Mar 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants