Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rotationMatrixFromPositionVelocity not normalized cross product leads to rendering artefacts #6640

Closed
xtassin opened this issue May 31, 2018 · 1 comment
Closed

rotationMatrixFromPositionVelocity not normalized cross product leads to rendering artefacts #6640

xtassin opened this issue May 31, 2018 · 1 comment

Comments

@xtassin
Copy link
Contributor

xtassin commented May 31, 2018

Method Cesium.Transforms.rotationMatrixFromPositionVelocity does not normalize the result of several cross product operations.

This leads to rendering artefacts similar to some observed in a different scenario (#3178) when a VelocityOrientationProperty is being used to generate a camera lookAt transform.
@hpinkos
Copy link
Contributor

hpinkos commented May 31, 2018

Thanks @xtassin, could you open a pull request with the fix? That would help us get this fix in faster.

xtassin added a commit to xtassin/cesium that referenced this issue May 31, 2018
@xtassin
Normalize cross product result for up vector
137b260 
At minima, normalizing the up vector obtained from cross product resolves issue CesiumGS#6640
Other cross product results in this function could also be normalized but only the up vector was causing the effect noticed in the mentioned issue.
@xtassin xtassin mentioned this issue May 31, 2018
Merged
xtassin added a commit to xtassin/cesium that referenced this issue Jul 31, 2018
@xtassin
Normalizing cross product results in rotationMatrixFromPositionVeloci…
8e69adc 
…ty method

Solving CesiumGS#6640
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xtassin @hpinkos