Fix crash when adding and removing a billboard before next update. #2630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As [reported on the forum](https://groups.google.com/d/msg/cesium-dev/Ti4jLsugBq4/13Qo5_daa68J), adding and then removing a billboard before the collection is updated causes a crash because we don't remove the billboards before trying to recreate the atlas. The new test I added fails in master but passes in this branch.
emackey
added a commit
to emackey/cesium
that referenced
this pull request
Apr 10, 2015
|
Tests pass, including new test. |
emackey
added a commit
that referenced
this pull request
Apr 10, 2015
Fix crash when adding and removing a billboard before next update.
|
Update CHANGES.md in master if you think it is warranted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported on the forum, adding and then removing a billboard before the collection is updated causes a crash because we don't remove the billboards before trying to recreate the atlas (and then we call
loadImageon the destroyed billboard). The new test I added fails in master but passes in this branch.