Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Material texture cache #2850

Merged
merged 2 commits into from
Jun 30, 2015
Merged

Remove Material texture cache #2850

merged 2 commits into from
Jun 30, 2015

Commits on Jun 30, 2015

  1. Remove Material texture cache 

    The Material texture cache caused many more problems than it solved, so
this removes it until a complete solution can be found.

This fix exposed several bad tests that were actually using the default
texture instead of waiting for an image material uniform to load.  These
tests have been fixed.

This fix also exposed another bug as well, which caused a material
rendered with the default texture and then destroyed to end up destroying
the default texture.  Since textures are not reference counted, I simply
added an `isDefault` flag for now and had Material.destroy only destroy
the texture if it was not the default texture.
    @mramato
    mramato committed Jun 30, 2015
    Configuration menu
    Copy the full SHA
    21fd562 View commit details
    Browse the repository at this point in the history

  2. Changes after review. 

    Cache the default texture and use reference comparison to avoid
destroying it.
    @mramato
    mramato committed Jun 30, 2015
    Configuration menu
    Copy the full SHA
    2ef4d6b View commit details
    Browse the repository at this point in the history