Fix PolygonGeometry per position height extrusion #2923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,6 +1,15 @@ | |||
| Change Log | |||
| ========== | |||
|
|
|||
| ### 1.11 - 2015-07-01 | |||
There was a problem hiding this comment.
Should be 1.13 - 2015-09-01
There was a problem hiding this comment.
Looks like you beat me to it 😄
|
Thanks! This also fixes the case where |
|
@hpinkos found an issue with normals when extruding up, but will handle it in a separate issue (since it wasn't a supported feature before anyway). |
mramato
added a commit
that referenced
this pull request
Aug 6, 2015
Fix PolygonGeometry per position height extrusion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mramato
This will also fix the issue of short extruded polygons not extruding, which I'm surprised no one has run into yet.