fix issue #4131 #4157
fix issue #4131 #4157
Conversation
|
Thanks for the fix, @AndreyOrlov. Can you update CHANGES.md? Also, sorry for the slow response; most of the team was at SIGGRAPH last week. @tfili can you review and merge this? Is it possible to write a reasonable unit test? For #4131. |
|
Everyone - we have a CLA. |
|
The change looks good. @AndreyOrlov could you merge in master. Also, can you add a unit test. Having a tesselated Thanks |
| @@ -1150,7 +1150,7 @@ define([ | |||
| entity.corridor = corridor; | |||
| corridor.positions = coordinates; | |||
| if (defined(polyline)) { | |||
| corridor.material = defined(polyline.material) ? polyline.material.color : Color.WHITE; | |||
| corridor.material = defined(polyline.material) ? polyline.material.color.getValue() : Color.WHITE; | |||
There was a problem hiding this comment.
getValue requires time as its first parameter, if we are 100% sure that .material.color will be a constant value (maybe it's impossible to make it time varying with kml?) then we should still use Iso860.MINIMUM_VALUE here. @tfili can you check if this is indeed always constant.
There was a problem hiding this comment.
Yes, colors in KML are always constant (excluding the highlight style in StyleMaps, which isn't supported in Cesium). I would just change it to use Iso860.MINIMUM_VALUE as @mramato suggested.
|
@tfili feel free to merge if you are happy. |
|
@AndreyOrlov Looks good. Need you to merge in master again. There appear to be another set of conflicts. I'll merge once it's updated. |
…clamp-to-ground-error
|
@tfili Done. |
|
Thanks @AndreyOrlov |
No description provided.