Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support html and css in Github Gists #4548

Merged
merged 5 commits into from
Nov 2, 2016
Merged

Support html and css in Github Gists #4548

merged 5 commits into from
Nov 2, 2016

Conversation

lilleyse
Copy link
Contributor

Fixes #4125

@emackey
Copy link
Contributor

emackey commented Oct 30, 2016

Does this break compatibility with old gists?

@lilleyse
Copy link
Contributor Author

Oh good point, it does. I'll fix that.

@lilleyse
Copy link
Contributor Author

Updated

@emackey
Copy link
Contributor

emackey commented Nov 1, 2016

I still think it's unfortunate that Sandcastle treats gists as proprietary data storage, rather than saving a working example to the gist. I think Sandcastle should save to the gist almost exactly what it offers for download, with the exception that (a) the references to Cesium should be via CDN rather than relative links, and (b) the JS file could be broken out to a separate file, as it is on this branch, so long as the HTML file references the JS file. Done correctly, we could easily enable Bl.ocks.org URLs to display working Sandcastle demos, outside of Sandcastle.

That said, if the team wants to merge this as a quick fix for lack of HTML save on gists, I'm not opposed.

@pjcozzi
Copy link
Contributor

pjcozzi commented Nov 1, 2016

I don't know the details here, but if this is too hacky, I would rather wait for a solid implementation since this isn't widely requests (albeit useful).

@lilleyse
Copy link
Contributor Author

lilleyse commented Nov 1, 2016

The change here is just mirroring the existing system, I think it's ok to go in now until we restructure things.

@pjcozzi pjcozzi merged commit dd2f13d into master Nov 2, 2016
@pjcozzi pjcozzi deleted the gist-html branch November 2, 2016 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants