Firefox OIT fix #4762
Merged
Firefox OIT fix #4762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilleyse
commented
Dec 17, 2016
| @@ -88,7 +88,7 @@ define([ | |||
| pixelDatatype : PixelDatatype.UNSIGNED_BYTE | |||
| }); | |||
|
|
|||
| if (context.depthStencilTexture) { | |||
| if (context.depthTexture) { | |||
There was a problem hiding this comment.
Not related - but a mistake from a search and replace I did in #4747
|
Very nice, thanks @lilleyse! |
This was referenced Dec 18, 2016
|
@lilleyse is there an issue that links to the Firefox bug for this so we can remove the workaround when the browser is fixed? |
|
No there isn't, thanks for the reminder. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4658
There seems to be an issue where a texture that is not initialized with a source and is bound to an FBO color attachment (besides the 0th) cannot be rendered to correctly.
So instead of passing
nulltopixelsI pass in an empty array buffer.I consider this just a workaround until the actual bug is fixed. I have a small test case that is displaying the same issue so I'm going to file a Firefox bug.