Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KML empty string for color #4826

Merged
merged 1 commit into from
Jan 9, 2017
Merged

KML empty string for color #4826

merged 1 commit into from
Jan 9, 2017

Conversation

hpinkos
Copy link
Contributor

@hpinkos hpinkos commented Jan 9, 2017

Replaces #4821

Some KMLs has empty color string for PlaceMarks style. In that case color parsed in Cesium NaN, NaN, NaN, NaN and Billboard wasn't visible.

@hpinkos hpinkos mentioned this pull request Jan 9, 2017
Closed
@pjcozzi
Copy link
Contributor

pjcozzi commented Jan 9, 2017

LGTM. Does anyone else want to look at this?

@mramato
Copy link
Contributor

mramato commented Jan 9, 2017

Please update CHANGES.md in master.

Thanks.

@mramato mramato merged commit 83305ae into master Jan 9, 2017
@mramato mramato deleted the kml-empty-color branch January 9, 2017 14:23
@hpinkos
Copy link
Contributor Author

hpinkos commented Jan 9, 2017

Done 668d722
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hpinkos @pjcozzi @mramato