Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose DEFAULT_OFFSET from Camera #4936

Merged
merged 1 commit into from
Mar 2, 2017
Merged

Expose DEFAULT_OFFSET from Camera #4936

merged 1 commit into from
Mar 2, 2017

Conversation

bampakoa
Copy link
Contributor

Closes #2599

@hpinkos
Copy link
Contributor

hpinkos commented Feb 3, 2017

Thanks for the pull request @bampakoa! We got your CLA emails and we'll try to review this next week.

@emackey
Copy link
Contributor

emackey commented Feb 3, 2017

Can we easily explain to users the difference between this and Camera.DEFAULT_VIEW_FACTOR? How does a user decide which one to use?

(Don't get me wrong, I like this change, I just want to protect the usability of the API).

@bampakoa
Copy link
Contributor Author

@hpinkos Do I need to elaborate further more on the documentation, as @emackey refers, in order for the PR to be reviewed?

@emackey
Copy link
Contributor

emackey commented Mar 2, 2017

@bagnell When you get a minute, what do you think of this?

@bagnell
Copy link
Contributor

bagnell commented Mar 2, 2017

@bampakoa I think this is great.
@emackey You can merge this whenever its ready.

@emackey
Copy link
Contributor

emackey commented Mar 2, 2017

Thanks @bampakoa. I'll add a note in CHANGES.md in master.

@emackey emackey merged commit bce5171 into CesiumGS:master Mar 2, 2017
emackey added a commit that referenced this pull request Mar 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants