Fix for default scale of oriented bounding box #6147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 23, 2018 17:10
…t, and what was actually used in default constructor
|
@hanbollar, thanks for the pull request! Maintainers, we have a signed CLA from @hanbollar, so you can review this at any time. I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
lilleyse
reviewed
Jan 23, 2018
| @@ -66,7 +66,7 @@ define([ | |||
| /** | |||
| * The transformation matrix, to rotate the box to the right position. | |||
| * @type {Matrix3} | |||
| * @default {@link Matrix3.IDENTITY} | |||
| * @default {@link Matrix3.ZERO} | |||
| */ | |||
| this.halfAxes = Matrix3.clone(defaultValue(halfAxes, Matrix3.ZERO)); | |||
There was a problem hiding this comment.
I think the changes here should be reversed. The doc is correct, but Matrix3.ZERO should be Matrix3.IDENTITY.
2x2x2 is correct because the half axes are 1x1x1 but the full cube is 2x2x2.
|
discussed the solution with @lilleyse and agreed to keep it at Matrix3.ZERO. This is ready for another look |
|
Thanks @hanbollar! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
constructor comment said scale was 2x2x2, comment above variable definition in constructor said Matrix3.IDENTITY, and variable was defaulted with Matrix3.ZERO. --> for orientedBoundingBox halfAxes variable.
updated to all be Matrix3.ZERO to match other types of default construction used in the rest of the class.