Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default translation, rotation, scale to node targeted for animation #6351

Merged
merged 3 commits into from
Mar 20, 2018

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented Mar 19, 2018

Fixes #6323

The animated triangle model (after modifications) now works.

@emackey can you take a look?

gltf-pipeline: CesiumGS/gltf-pipeline#356. A test is in that PR.

Copy link
Contributor

@emackey emackey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, fixes the problem. No tests were added, but our test harness is pretty coarse here and can't really tell if a node is being animated or not. Whoops, missed the comment about a test being added to pipeline. Nice!

Added one small suggestion, feel free to ignore :)

var path = target.path;
// Ignore animations that target 'weights'
if (path === 'translation' || path === 'rotation' || path === 'scale') {
nodes[node] = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for readability's sake, can we rename the index variable here? Such as nodes[nodeId] = true; or similar.

@lilleyse
Copy link
Contributor Author

@emackey Updated.

@emackey emackey merged commit 3f075ad into master Mar 20, 2018
@emackey emackey deleted the node-trs-default branch March 20, 2018 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants