Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add zIndex to CZML #6708

Merged
merged 4 commits into from
Jun 21, 2018
Merged

Add zIndex to CZML #6708

merged 4 commits into from
Jun 21, 2018

Conversation

hpinkos
Copy link
Contributor

@hpinkos hpinkos commented Jun 19, 2018 •
edited
Loading

Applicable to corridor, ellipse, polygon and rectangle.

CC @shunter

@cesium-concierge
Copy link

Signed CLA is on file.

@hpinkos, thanks for the pull request! Maintainers, we have a signed CLA from @hpinkos, so you can review this at any time.

⚠️ I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@hpinkos
Copy link
Contributor Author

hpinkos commented Jun 21, 2018

Since we merged in @likangning93 CZML changes, I want to get this merged in for this release too.

@ggetz can you review?

likangning93
likangning93 reviewed Jun 21, 2018
View reviewed changes
Copy link
Contributor

@likangning93 likangning93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small thing, otherwise this looks good to me.

Apps/Sandcastle/gallery/CZML ZIndex.html Outdated
<meta charset="utf-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1, minimum-scale=1, user-scalable=no">
<meta name="description" content="CZML Circles and Ellipses">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update description?

@hpinkos
Copy link
Contributor Author

hpinkos commented Jun 21, 2018

@likangning93 ready. I also made some tweaks to CHANGES.md since there was a lot of duplication for your two polyline on terrain bullet points, and overlap between your CZML PR and mine.

@ggetz
Copy link
Contributor

ggetz commented Jun 21, 2018

Looks good to me! Thanks @hpinkos!

@ggetz ggetz merged commit 21dafa7 into master Jun 21, 2018
@ggetz ggetz deleted the czml-zindex branch June 21, 2018 18:34
@shunter
Copy link
Contributor

shunter commented Jun 21, 2018

@hpinkos - is zIndex supposed to be an integer or a floating point value? Digging through the code it's not entirely clear.

@hpinkos
Copy link
Contributor Author

hpinkos commented Jun 21, 2018 •
edited
Loading

@shunter It will work with either, and it works with negative values, but I think an integer makes the most sense if it had to be one or the other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@likangning93 likangning93 likangning93 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hpinkos @cesium-concierge @ggetz @shunter @likangning93