Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intermittent clamp to ground failure #6930

Merged
merged 2 commits into from
Aug 17, 2018
Merged

Conversation

hpinkos
Copy link
Contributor

@hpinkos hpinkos commented Aug 16, 2018

Fixes #6858

If the tile isn't finished loading, tile.data is the upsampled data from the parent tile, which isn't the correct height for that LOD.

@hpinkos hpinkos requested a review from bagnell August 16, 2018 19:01
@cesium-concierge
Copy link

Thanks for the pull request @hpinkos!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@hpinkos
Copy link
Contributor Author

hpinkos commented Aug 16, 2018

@bagnell it's easy to reproduce the issue in master if you use the examle in #6858 and follow these steps:

  • Run the example
  • Once the globe is loaded, open the network tab in the debugger and throttle the download speed (i created a custom throttle profile with 4048 kb/s download speed)
  • Click the 'Set View To Entities' button while

@bagnell
Copy link
Contributor

bagnell commented Aug 17, 2018

👍

@bagnell bagnell merged commit 7a1b495 into master Aug 17, 2018
@bagnell bagnell deleted the fix-height-reference branch August 17, 2018 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants