Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add octahedral projection #7107

Merged
merged 3 commits into from
Oct 4, 2018
Merged

Add octahedral projection #7107

merged 3 commits into from
Oct 4, 2018

Conversation

OmarShehata
Copy link
Contributor

This is a work in progress. It might need some cleanup like moving the shaders into separate files/style changes, but this takes in an array of cubemaps and packs each into a flat square by flattening an octahedron, and stacks them horizontally.

This is to make the IBL work @bagnell is working on work in WebGL 1.

@cesium-concierge
Copy link

Thanks for the pull request @OmarShehata!

  • ✔️ Signed CLA found.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@bagnell
Copy link
Contributor

bagnell commented Oct 4, 2018

Thanks @OmarShehata! I'm merging and I'll make some edits in the ibl branch.

@bagnell bagnell merged commit 8a34bcc into CesiumGS:ibl Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants