Configurable volume width for sampleHeight and clampToHeight #7287
Conversation
|
Thanks for the pull request @lilleyse!
Reviewers, don't forget to make sure that:
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
lilleyse
force-pushed
the
configurable-pick-width
branch
from
535877f
to
e70d371
Compare
|
Thanks again for your contribution @lilleyse! No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy? I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
lilleyse
force-pushed
the
configurable-pick-width
branch
2 times, most recently
from
e9236ec
to
4eb6d1e
Compare
|
Updated changes and added some tests. This is ready to review now. @bagnell could you check this out? |
| @@ -777,16 +778,18 @@ define([ | |||
| camera.frustum.far = 10000000000.0; | |||
| } | |||
|
|
|||
| var pickOffscreenDefaultWidth = 0.1; | |||
There was a problem hiding this comment.
Can you make this a constant or is it meant to be configurable?
There was a problem hiding this comment.
I hadn't thought about making it configurable, but I might as well. I marked it as private though since the preferred way is to pass the width to the function.
Source/Scene/Scene.js
Outdated
| @@ -3898,15 +3904,15 @@ define([ | |||
| (objectsToExclude.indexOf(object.id) > -1); | |||
| } | |||
|
|
|||
| function getRayIntersection(scene, ray, objectsToExclude, requirePosition, async) { | |||
| function getRayIntersection(scene, ray, objectsToExclude, width, requirePosition, async) { | |||
There was a problem hiding this comment.
Can you rename the async argument since it'll be a reserved word?
Source/Scene/Scene.js
Outdated
| @@ -3957,22 +3963,22 @@ define([ | |||
| } | |||
| } | |||
|
|
|||
| function getRayIntersections(scene, ray, limit, objectsToExclude, requirePosition, async) { | |||
| function getRayIntersections(scene, ray, limit, objectsToExclude, width, requirePosition, async) { | |||
There was a problem hiding this comment.
Same comment throughout about async.
|
@bagnell Ready |
Fixes #7248
The user can now provide their own volume width when sampling height which helps get better results when sampling sparse point clouds. Screenshots of St. Helens with this option are in #7248.
Also the default width changed from 0.01 meters to 0.1 meters to help improve the common case.
To do: