Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve visibility check in tileset traversal #7289

Merged
merged 2 commits into from
Dec 17, 2018
Merged

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented Nov 28, 2018

This is a better way to set updateVisibilityFrame in the 3D Tiles traversal code which is used to limit the number of times a tile's visibility can be computed during each traversal.

The previous way had an edge case where the visibility frame would not get reset after a previous pass within the same frame if the tile's visibility was checked but it wasn't actually visited. This can happen with the cull-with-children-bounds optimization. I only hit this by calling pickFromRay after a pick, and it only happened sometimes.

  • CHANGES.md

@cesium-concierge
Copy link

Thanks for the pull request @lilleyse!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@lilleyse
Copy link
Contributor Author

lilleyse commented Dec 4, 2018

Updated CHANGES.md. I'm not really sure how to test this without going through a lot of trouble. In any case the behavior is nearly the same as before and all tests pass locally.

@ggetz can you review?

@ggetz
Copy link
Contributor

ggetz commented Dec 17, 2018

Tested a few different tilesets with picking and behavior is the same, so I think this should be good to merge. Thanks @lilleyse !

@ggetz ggetz merged commit 2de1fe2 into master Dec 17, 2018
@lilleyse lilleyse deleted the fix-visibility-check branch December 17, 2018 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants