Change usage of followSurface to arcType. Add CZML property for it. #7582
Conversation
|
Thanks for the pull request @shehzan10!
Reviewers, don't forget to make sure that:
|
|
@mramato Would you mind looking at this? |
|
I would like to get this merged before the release. cc @shunter, we need to add this new CZML property to |
|
This looks good to me! Thanks @shehzan10 @shunter let me know if there's anything else we need to do |
|
FYI looks like this change causes a crash when loading any CZML file which uses followSurface. I guess there are no tests whatsoever for that codepath? |
|
oh no, thanks @shunter. looking into that right now |
| // See https://github.com/AnalyticalGraphicsInc/cesium/pull/7582#discussion_r258695385 | ||
| if (defined(polylineData.followSurface) && !defined(polylineData.arcType)) { | ||
| if (polyline.followSurface) { | ||
| processPacketData(ArcType, polyline, 'arcType', ArcType.GEODESIC, interval, sourceUri, entityCollection); |
There was a problem hiding this comment.
In addition to several coding errors, this approach won't work in general, since followSurface could be time-varying. Rather than turning a boolean into an ArcType, this needs to turn a Property<boolean> into a Property<ArcType> which is essentially map since Property objects are basically functions.
Change the existing usages
followSurfacetoarcType.CZML requires a new property to be added, which this PR also adds.
Fixes #7572