Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable Chrome for travis builds #8069

Merged
merged 1 commit into from
Aug 15, 2019
Merged

Re-enable Chrome for travis builds #8069

merged 1 commit into from
Aug 15, 2019

Conversation

mramato
Copy link
Contributor

@mramato mramato commented Aug 15, 2019

Looks like the Chrome bug (or karma issue?) that prevented them from running is now fixed!

Looks like the Chrome bug (or karma issue?) that prevented them from
running is now fixed.
@cesium-concierge
Copy link

Thanks for the pull request @mramato!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@mramato
Copy link
Contributor Author

mramato commented Aug 15, 2019

@OmarShehata can you hit merge on this?

@OmarShehata
Copy link
Contributor

Looks good to me, thanks Matt!

@OmarShehata OmarShehata merged commit 559de8e into master Aug 15, 2019
@OmarShehata OmarShehata deleted the chrome-works-again branch August 15, 2019 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants