Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleted is array #8779

Merged
merged 2 commits into from
Apr 21, 2020
Merged

Deleted is array #8779

merged 2 commits into from
Apr 21, 2020

Conversation

YVin3D
Copy link
Contributor

@YVin3D YVin3D commented Apr 21, 2020

Fixes #8775

@cesium-concierge
Copy link

Thanks for the pull request @YoussefV!

  • ✔️ Signed CLA found.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

lilleyse
lilleyse reviewed Apr 21, 2020
View reviewed changes
Copy link
Contributor

@lilleyse lilleyse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @YoussefV, just some nitpicks from me about the CHANGES.md entry.

CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
@YVin3D @lilleyse
Update CHANGES.md
7fc216a 
Co-Authored-By: Sean Lilley <lilleyse@gmail.com>
@lilleyse
Copy link
Contributor

Thanks @YoussefV!

@lilleyse lilleyse merged commit 83a0e7a into master Apr 21, 2020
@lilleyse lilleyse deleted the deleted-isArray branch April 21, 2020 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilleyse lilleyse lilleyse left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove deprecated isArray.js
3 participants
@YVin3D @cesium-concierge @lilleyse