Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw walls with positions in order given #8955

Merged
merged 3 commits into from
Jun 15, 2020
Merged

Draw walls with positions in order given #8955

merged 3 commits into from
Jun 15, 2020

Conversation

hpinkos
Copy link
Contributor

@hpinkos hpinkos commented Jun 12, 2020

Fixes #8708

We had logic to reverse the order of the wall positions to give them a counter-clockwise winding order. However, I can't see a reason for doing this and I think it was a mistake that got copy/pasted in based on how we handle positions for polygons. This removes that check and uses the positions passed in by the end user in the order they were given to draw the wall.

localhost example

@cesium-concierge
Copy link

Thanks for the pull request @hpinkos!

  • ✔️ Signed CLA found.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@mramato
Copy link
Contributor

mramato commented Jun 15, 2020

Looks good to me and I can't think of any reasons either. Making them uniform really doesn't make sense since users would need to be able to control the facing of the material.

@mramato mramato merged commit f35b743 into master Jun 15, 2020
@mramato mramato deleted the wall-order branch June 15, 2020 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Direction of image on a wall is inconsistent
3 participants