Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix walls when first and last positions are equal #9044

Merged
merged 2 commits into from
Jul 20, 2020
Merged

Fix walls when first and last positions are equal #9044

merged 2 commits into from
Jul 20, 2020

Conversation

hpinkos
Copy link
Contributor

@hpinkos hpinkos commented Jul 20, 2020

Fixes #9043

We were incorrectly using the wrapAround options for arrayRemoveDuplicates.

@cesium-concierge
Copy link

Thanks for the pull request @hpinkos!

  • ✔️ Signed CLA found.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@hpinkos
Copy link
Contributor Author

hpinkos commented Jul 20, 2020

@YoussefV could you review?

@lilleyse lilleyse mentioned this pull request Jul 20, 2020
Merged
@YVin3D YVin3D merged commit e6a09ae into master Jul 20, 2020
@YVin3D YVin3D deleted the fix-wall-wrapping branch July 20, 2020 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wall missing first segment
3 participants
@hpinkos @cesium-concierge @YVin3D