Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show/hide collections #9307

Merged
merged 5 commits into from
Jan 30, 2021
Merged

Show/hide collections #9307

merged 5 commits into from
Jan 30, 2021

Conversation

hpinkos
Copy link
Contributor

@hpinkos hpinkos commented Jan 5, 2021

Adds show property to BillboardCollection, EntityCluster, LabelCollection, PointPrimitiveCollection, and PolylineCollection for a convenient way to control show of the entire collection

@cesium-concierge
Copy link

Thanks for the pull request @hpinkos!

  • ✔️ Signed CLA found.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@hpinkos
Copy link
Contributor Author

hpinkos commented Jan 19, 2021

@IanLilleyT can you review?

Source/DataSources/EntityCluster.js Outdated Show resolved Hide resolved
Specs/Scene/LabelCollectionSpec.js Outdated Show resolved Hide resolved
Specs/Scene/PointPrimitiveCollectionSpec.js Outdated Show resolved Hide resolved
Specs/Scene/LabelCollectionSpec.js Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
@hpinkos
Copy link
Contributor Author

hpinkos commented Jan 25, 2021

Thanks @IanLilleyT ! This is ready now

@hpinkos
Copy link
Contributor Author

hpinkos commented Jan 29, 2021

bump @IanLilleyT

@IanLilleyT IanLilleyT merged commit 95b96bf into master Jan 30, 2021
@IanLilleyT IanLilleyT deleted the show-collections branch January 30, 2021 19:47
@IanLilleyT
Copy link
Contributor

Thank @hpinkos , merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants