Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Math.previousPowerOfTwo #9310

Merged
merged 2 commits into from
Feb 1, 2021
Merged

Added Math.previousPowerOfTwo #9310

merged 2 commits into from
Feb 1, 2021

Conversation

IanLilleyT
Copy link
Contributor

This PR adds Math.previousPowerOfTwo (Math.nextPowerOfTwo already exists)

Also improved the docs and specs to handle out of range inputs since Javascript bitwise operations convert operands to signed 32-bit int

@cesium-concierge
Copy link

Thanks for the pull request @IanLilleyT!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@lilleyse
Copy link
Contributor

lilleyse commented Feb 1, 2021

Looks good, thanks @IanLilleyT

@lilleyse lilleyse merged commit 0a60a51 into master Feb 1, 2021
@lilleyse lilleyse deleted the powerOfTwoImprovements branch February 1, 2021 13:59
@lilleyse
Copy link
Contributor

lilleyse commented Feb 1, 2021

There are a few PRs including this that need updates to CHANGES.md. @IanLilleyT's going to push that to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants