Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ellipsoid geodsic surface distance nan #9316

Merged

Conversation

littlemurph
Copy link
Contributor

@littlemurph littlemurph commented Jan 12, 2021

This PR fixes: #9248
Given certain input, cosineTwiceSigmaMidpoint in the vincentyInverseFormula could be -INFINITY which was not being checked by the isNaN. Changed to isFinite to cover both cases.

@cesium-concierge
Copy link

Thanks for the pull request @littlemurph!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@hpinkos
Copy link
Contributor

hpinkos commented Jan 12, 2021

Thanks for the PR, @littlemurph! I'll try to review this before the next release.
In the meantime, it looks like one of your files is failing for code formatting. If you run npm run prettier it should fix it. Also, please add a comment to CHANGES.md.

Thanks!

@littlemurph
Copy link
Contributor Author

Great thanks! I think I have everything in order now. Let me know if I missed anything else.

@IanLilleyT IanLilleyT merged commit 4c7fb7c into CesiumGS:master Feb 3, 2021
@IanLilleyT
Copy link
Contributor

Thanks @littlemurph! I confirmed the problem and the fix and made a small tweak to the test. Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EllipsoidGeodesic surfaceDistance is NaN
4 participants