-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom heightmap terrain provider #9604
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for the pull request @IanLilleyT!
Reviewers, don't forget to make sure that:
|
lilleyse
reviewed
Jun 15, 2021
@lilleyse This is ready for another review |
The updates look good. eslint and tests pass locally We're still figuring out why all branches are suddenly failing CI after the travis-ci.org -> travis.ci.com switch. That doesn't need to hold up this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
CustomHeightmapTerrainProvider
, aTerrainProvider
that lets you set height values inside a callback function. This way you can create procedural terrain very easily without having to create a whole newTerrainProvider
subclass. However, there are some limitations such as no water mask, no vertex normals, and no availability, so a full-fledgedTerrainProvider
is still the right thing to do a lot of the time.One example: Procedural terrain in
CustomHeightmapTerrainProvider
dropdown of the Terrain Sandcastle (localhost).Another example: Sine wave
Local Sandcastle
This is the code that does it: