Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ability to "unset" material image #9644

Merged
merged 11 commits into from
Jul 8, 2021
Merged

Fix ability to "unset" material image #9644

merged 11 commits into from
Jul 8, 2021

Commits on Jul 3, 2021

  1. Fix material update function so it checks for undefined images

    @j9liu
    j9liu committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    eaef299 View commit details
    Browse the repository at this point in the history

  2. Use uniformValue instead of uniform.image

    @j9liu
    j9liu committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    6d70830 View commit details
    Browse the repository at this point in the history

  3. Fix setting material to DefaultImageId

    @j9liu
    j9liu committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    5304709 View commit details
    Browse the repository at this point in the history

  4. Prevent overwrite of the material's default texture

    @j9liu
    j9liu committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    94b470b View commit details
    Browse the repository at this point in the history

  5. Add Material tests for image changes

    @j9liu
    j9liu committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    b7922ba View commit details
    Browse the repository at this point in the history

  6. Handle case where Material image uri is invalid

    @j9liu
    j9liu committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    a22c652 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2021

  1. Reorganize Material updateFunction code and tests

    @j9liu
    j9liu committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    db9b207 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2021

  1. Clean up update function code

    @j9liu
    j9liu committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    270fd9e View commit details
    Browse the repository at this point in the history

  2. Add check for undefined texture

    @j9liu
    j9liu committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    5a2c143 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2021

  1. Adjust destroy calls

    @j9liu
    j9liu committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    d114b00 View commit details
    Browse the repository at this point in the history

  2. Add missing destroy case

    @j9liu
    j9liu committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    b383d47 View commit details
    Browse the repository at this point in the history