Fix typo in regex for GB postcodes #83
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected a missing dash in the regular expression used for postcode validation. The old regex failed to properly validate certain postcodes from the list of valid examples, despite the validate function working correctly. Specifically, the postcodes "W1A 0AX" and "W1U 1BW" (without the redundant spaces) were not validated by the regex due to the missing dash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected a missing dash in the regular expression used for postcode validation. The old regex failed to properly validate certain postcodes from the list of valid examples, despite the validate function working correctly.
Specifically, the postcodes "W1A 0AX" and "W1U 1BW" (without the redundant spaces) were not validated by the regex due to the missing dash.
It's probably due to an issue with the ValidationRegex.DOC on page 6 here https://www.gov.uk/government/uploads/system/uploads/attachment_data/file/488478/Bulk_Data_Transfer_-_additional_validation_valid_from_12_November_2015.pdf
When you copy the regex it fails to copy the dash as well