Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue15 Resolves: #15. Log4j logging implemented, readme updated with basic configuration file description. #40

Merged
merged 1 commit into from
Mar 13, 2019
Merged

issue15 Resolves: #15. Log4j logging implemented, readme updated with basic configuration file description. #40

merged 1 commit into from
Mar 13, 2019

Conversation

echerniak
Copy link
Contributor

No description provided.

@echerniak echerniak added enhancement New feature or request docs Concerns documentation code Concerns code config Concerns configuration file labels Mar 13, 2019
@echerniak echerniak added this to the Release 0.1.0. milestone Mar 13, 2019
sberdyshev
sberdyshev approved these changes Mar 13, 2019
View reviewed changes
Copy link
Contributor

@sberdyshev sberdyshev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for now.
Will need to shift to slf4j in the future

@echerniak echerniak merged commit adcebb2 into develop Mar 13, 2019
@sberdyshev sberdyshev deleted the feature/issue15_logging branch March 15, 2019 15:46
This was referenced Mar 15, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sberdyshev sberdyshev sberdyshev approved these changes

Assignees

@echerniak echerniak

Labels
code Concerns code config Concerns configuration file docs Concerns documentation enhancement New feature or request
Projects
None yet
Milestone
Release 0.1.0.
Development

Successfully merging this pull request may close these issues.
2 participants
@echerniak @sberdyshev