Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: downgrade to checkout v3 when building releases in non-GH containers #1352

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Dec 6, 2023

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

Looks like checkout@v4 action causes some problems with the quay container (see actions/checkout#1474), this PR just adds an exception for it to use the previous v3 checkout action.

Issue

If applicable, what issue does this address?

Closes: #1351

Testing

If relevant, please state how this was tested. All changes must be tested to work:

Test build job

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

@ClementTsang ClementTsang marked this pull request as ready for review December 6, 2023 22:36
@ClementTsang ClementTsang merged commit 300f667 into main Dec 6, 2023
39 checks passed
@ClementTsang ClementTsang deleted the fix_quay_build_job branch December 6, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly builds aren't being generated nightly
1 participant