Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare nullable parameter types explicitly for PHP 8.4 compatibility #197

Merged

Conversation

W0rma
Copy link
Contributor

@W0rma W0rma commented Jul 26, 2024

https://wiki.php.net/rfc/deprecate-implicitly-nullable-types deprecates implicitly nullable parameter types in PHP 8.4

Copy link
Contributor

@burned42 burned42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@TavoNiievez TavoNiievez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@TavoNiievez TavoNiievez merged commit 9b77251 into Codeception:main Jul 26, 2024
8 checks passed
@W0rma W0rma deleted the explicit-nullable-parameter-types branch July 29, 2024 04:24
@TavoNiievez TavoNiievez added this to the 3.5.0 milestone Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants