Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit Symfony pre-built assertions #198

Merged
merged 1 commit into from
Aug 18, 2024

Conversation

TavoNiievez
Copy link
Member

@TavoNiievez TavoNiievez commented Aug 7, 2024

Symfony already includes a large list of assertions.
module-symfony users should not have to give them up when deciding to use Codeception.

So this PR is an attempt to add to Codeception's $I-> syntax the assertions that are already built into Symfony, making the module a functional testing superset for Symfony rather than a replacement or competitor.

The obvious benefit of doing this is that people who already have tests in Symfony will find it easier to migrate to Codeception as it will not be necessary to spend time finding and rewriting tests in the Codeception equivalent of that assertion (where there is one).

@TavoNiievez TavoNiievez force-pushed the symfony-asserts branch 6 times, most recently from 1987a3d to 6a99658 Compare August 13, 2024 00:43
@TavoNiievez TavoNiievez force-pushed the symfony-asserts branch 4 times, most recently from 110c0cd to 6cc7f88 Compare August 15, 2024 02:53
@TavoNiievez TavoNiievez marked this pull request as ready for review August 15, 2024 03:40
@TavoNiievez TavoNiievez changed the title [WIP] get the assertions inherent to Symfony Get the assertions inherent to Symfony Aug 15, 2024
@TavoNiievez TavoNiievez changed the title Get the assertions inherent to Symfony Inherit Symfony pre-built assertions Aug 18, 2024
@TavoNiievez TavoNiievez merged commit 72cf4d1 into Codeception:main Aug 18, 2024
8 checks passed
@TavoNiievez TavoNiievez added this to the 3.5.0 milestone Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant