Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve lazyload effect #71

Closed
selul opened this issue Jan 9, 2019 · 3 comments
Closed

improve lazyload effect #71

selul opened this issue Jan 9, 2019 · 3 comments
Labels
enhancement Request to improve or optimize an existing feature or functionality in the project

Comments

@selul
Copy link
Contributor

selul commented Jan 9, 2019

The current lazyload fade in effect might need some adjustments, here are some possible suggestions:

  1. we can try to get rid of the border-radius for now or decreaza it a bit, now is 5%
  2. decrease the opacity from .5 to something smaller ?

@abaicus @cosmin-serbanescu do you have any suggestions on this, you can see this in action on codeinwp.com .
@selul selul added the enhancement Request to improve or optimize an existing feature or functionality in the project label Jan 9, 2019
@cosmin-serbanescu
Copy link

Yes, I would definitely get rid of that border radius, the fadein+blur looks great though.
I took a look at what others are doing - like solid color (predominant color) or spinner while loading but to be honest this blurring technique seems to look way better.

@abaicus
Copy link
Contributor

abaicus commented Jan 9, 2019 •
edited
Loading

I agree with Cosmin. I think that the border radius should be removed. I think maybe bringing up the opacity would work a bit better - something like .75. What do you think?

image

image

@selul
Copy link
Contributor Author

selul commented Jan 9, 2019 •
edited
Loading

Yes, is looking great, I will bundle this in the new version, Thanks guys for feedback.

selul added a commit that referenced this issue Jan 9, 2019
@selul
fix: improve lazyload fade in effect, fixes #71
eca0321
@selul selul closed this as completed in eb0f76c Jan 21, 2019
selul pushed a commit that referenced this issue Jan 21, 2019
@semantic-release-bot
chore(release): 2.0.0 [skip ci]
21fe081 
### [2.0.0](v1.1.2...v2.0.0) (2019-01-21)

#### Bug Fixes

* errors on low PHP environments when PHP_INT_MIN constant is not available ([44eb4af](44eb4af))

* fix tag replacement on lazy load, preserve image size when found ([5c6ef70](5c6ef70))

* improve image size replacement mapping for custom image sizes ([d816ccb](d816ccb))

* improve lazyload fade in effect, fixes [#71](#71) ([eb0f76c](eb0f76c))

* possible issue with image replacement not taking place when other buffer handler is registered ([3ce600a](3ce600a))

* resize behaviour for WordPress defined image sizes, preserve cropping for custom sizes ([a42f830](a42f830))

#### Documentation

* add basic faq to readme file ([2c09d26](2c09d26))

* adds contributor related docs and github templates ([c7bbce2](c7bbce2))

#### Features

* adds new service schema ([330fba0](330fba0))

* adds watermark integration along with various options for watermark position ([6a4538a](6a4538a))

* deactivate plugin on lower php versions, adds notice for PHP for upgrade ([58d2607](58d2607))

#### Performance Improvements

* improve srcset replacement, use attachement id when present ([5587221](5587221))

* improve type casting on size constrain ([589b046](589b046))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Request to improve or optimize an existing feature or functionality in the project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@selul @abaicus @cosmin-serbanescu