-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Idle status postmessages #7514
Idle status postmessages #7514
Conversation
We send User_Idle when user become idle, but there was no similar message when user become active again. Signed-off-by: Szymon Kłos <szymon.klos@collabora.com> Change-Id: If0fe48456dc5ba24357bde792254c11c14517170
20cc401
to
262c789
Compare
Get_User_State postmessage is used to query user status. If user is active or idle and how many seconds ago there was registered last activity. { State: 'idle', Elapsed: 2.3 } Signed-off-by: Szymon Kłos <szymon.klos@collabora.com> Change-Id: I354c329b48d61df380455ce3c4a4732e78b138ab
262c789
to
bac5747
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, but haven't tested yet 👍
Waiting for @Rash419 to be merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected : )
Should we also add button for 'Get_User_State' in our framed.doc.html ? |
@eszkadev Quick followup question for integrating:
Can you tell what exactly last activity means in this case? Is it bound to mouse/keyboard events and is it also sent back if the user is still considered active? |
Yes, it is bound to mouse / keyboard activity. Timer is always reset on any activity and Get_User_State_Resp returns time elapsed between that time and Date.now() |
This was introduced in #7514 Signed-off-by: Hubert Figuière <hub@collabora.com> Change-Id: I98b9b5b04742541904afa2361ac961498a54c29d
Done in #7876 |
This was introduced in #7514 Signed-off-by: Hubert Figuière <hub@collabora.com> Change-Id: I98b9b5b04742541904afa2361ac961498a54c29d
This was introduced in #7514 Signed-off-by: Hubert Figuière <hub@collabora.com> Change-Id: I98b9b5b04742541904afa2361ac961498a54c29d
This was introduced in #7514 Signed-off-by: Hubert Figuière <hub@collabora.com> Change-Id: I98b9b5b04742541904afa2361ac961498a54c29d
This was introduced in CollaboraOnline/online#7514 Signed-off-by: Hubert Figuière <hub@collabora.com> Change-Id: I98b9b5b04742541904afa2361ac961498a54c29d
This was introduced in CollaboraOnline/online#7514 Signed-off-by: Hubert Figuière <hub@collabora.com> Change-Id: I98b9b5b04742541904afa2361ac961498a54c29d
postmessage: handle Get_User_State
Get_User_State postmessage is used to query user status.
If user is active or idle and how many seconds ago there
was registered last activity.
{
state: 'idle',
elapsed: 2.3
}
postmessage: send User_Active when become active again
We send User_Idle when user become idle, but there was no
similar message when user become active again.