Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idle status postmessages #7514

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Conversation

eszkadev
Copy link
Contributor

postmessage: handle Get_User_State

Get_User_State postmessage is used to query user status.
If user is active or idle and how many seconds ago there
was registered last activity.

{
state: 'idle',
elapsed: 2.3
}


postmessage: send User_Active when become active again

We send User_Idle when user become idle, but there was no
similar message when user become active again.

We send User_Idle when user become idle, but there was no
similar message when user become active again.

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: If0fe48456dc5ba24357bde792254c11c14517170
@eszkadev eszkadev force-pushed the private/eszkadev/idle-status-postmessage branch from 20cc401 to 262c789 Compare October 24, 2023 08:24
Get_User_State postmessage is used to query user status.
If user is active or idle and how many seconds ago there
was registered last activity.

{
    State: 'idle',
    Elapsed: 2.3
}

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I354c329b48d61df380455ce3c4a4732e78b138ab
@eszkadev eszkadev force-pushed the private/eszkadev/idle-status-postmessage branch from 262c789 to bac5747 Compare October 24, 2023 08:30
@pedropintosilva pedropintosilva requested review from juliushaertl and Rash419 and removed request for juliushaertl October 24, 2023 09:53
Copy link
Member

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but haven't tested yet 👍

@pedropintosilva
Copy link
Contributor

Waiting for @Rash419 to be merged

Copy link
Contributor

@Rash419 Rash419 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected : )

@Rash419 Rash419 merged commit 6d7198c into master Oct 24, 2023
12 checks passed
@Rash419 Rash419 deleted the private/eszkadev/idle-status-postmessage branch October 24, 2023 12:09
@Rash419
Copy link
Contributor

Rash419 commented Oct 24, 2023

Should we also add button for 'Get_User_State' in our framed.doc.html ?

@juliushaertl
Copy link
Member

@eszkadev Quick followup question for integrating:

Get_User_State postmessage is used to query user status.
If user is active or idle and how many seconds ago there
was registered last activity.

Can you tell what exactly last activity means in this case? Is it bound to mouse/keyboard events and is it also sent back if the user is still considered active?

@eszkadev
Copy link
Contributor Author

Yes, it is bound to mouse / keyboard activity. Timer is always reset on any activity and Get_User_State_Resp returns time elapsed between that time and Date.now()

hfiguiere added a commit that referenced this pull request Dec 20, 2023
This was introduced in #7514

Signed-off-by: Hubert Figuière <hub@collabora.com>
Change-Id: I98b9b5b04742541904afa2361ac961498a54c29d
@hfiguiere
Copy link
Contributor

Should we also add button for 'Get_User_State' in our framed.doc.html ?

Done in #7876

hfiguiere added a commit that referenced this pull request Dec 20, 2023
This was introduced in #7514

Signed-off-by: Hubert Figuière <hub@collabora.com>
Change-Id: I98b9b5b04742541904afa2361ac961498a54c29d
hfiguiere added a commit that referenced this pull request Jan 2, 2024
This was introduced in #7514

Signed-off-by: Hubert Figuière <hub@collabora.com>
Change-Id: I98b9b5b04742541904afa2361ac961498a54c29d
timar pushed a commit that referenced this pull request Jan 3, 2024
This was introduced in #7514

Signed-off-by: Hubert Figuière <hub@collabora.com>
Change-Id: I98b9b5b04742541904afa2361ac961498a54c29d
andreasma pushed a commit to freeonlineoffice/online that referenced this pull request Jan 6, 2024
This was introduced in CollaboraOnline/online#7514

Signed-off-by: Hubert Figuière <hub@collabora.com>
Change-Id: I98b9b5b04742541904afa2361ac961498a54c29d
s8321414 pushed a commit to MODAODF/modaodfweb that referenced this pull request Jul 12, 2024
This was introduced in CollaboraOnline/online#7514

Signed-off-by: Hubert Figuière <hub@collabora.com>
Change-Id: I98b9b5b04742541904afa2361ac961498a54c29d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants