Server audit dialog (master) #9204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.github.com/in/57789?s=60&v=4){kind=small}
eszkadev
force-pushed
the
private/eszkadev/server-audit-dialog-master
branch
from
49e196e
to
d1ba152
Compare
eszkadev
force-pushed
the
private/eszkadev/server-audit-dialog-master
branch
3 times, most recently
from
9beb483
to
062685b
Compare
gokaysatir
reviewed
Jun 3, 2024
eszkadev
force-pushed
the
private/eszkadev/server-audit-dialog-master
branch
from
062685b
to
015e275
Compare
eszkadev
force-pushed
the
private/eszkadev/server-audit-dialog-master
branch
from
015e275
to
f9fd24f
Compare
gokaysatir
reviewed
Jun 3, 2024
eszkadev
force-pushed
the
private/eszkadev/server-audit-dialog-master
branch
from
f9fd24f
to
2c5cf84
Compare
This is dialog shown only for the admin users, or if is_admin property is missing in the userPrivateInfo then - all users. Signed-off-by: Szymon Kłos <szymon.klos@collabora.com> Change-Id: Ife8355816b1afe6765ef5edc6fe2d3db5e043532
eszkadev
force-pushed
the
private/eszkadev/server-audit-dialog-master
branch
5 times, most recently
from
1b24b1d
to
e7eed34
Compare
eszkadev
force-pushed
the
private/eszkadev/server-audit-dialog-master
branch
from
05aaa59
to
fc0f8c3
Compare
we use { code: string, status: string } entries to describe a
problem
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I21dacc0fa7b2c48f08ea2923e73da58fe33f976e
Treeview can now show links, not only text Signed-off-by: Szymon Kłos <szymon.klos@collabora.com> Change-Id: I49f53f598355f398841947adaefb475cfa6ba7d1
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com> Change-Id: Ic64ca75b2bca8b783729285f6ffa43b78f94cc0b
and get real state of missing is_admin property Signed-off-by: Szymon Kłos <szymon.klos@collabora.com> Change-Id: I988ac357d2eca27e0bdf55d144f33caf780be5f4
so it will not be annoying Signed-off-by: Szymon Kłos <szymon.klos@collabora.com> Change-Id: Idefa59b855160035a08da7dce936e83c1475995d
Always show entries for things we check with status: red/green circle. Initialize values on server start. If any user will not have is_audit then we will mark that and later admin will see warning. Signed-off-by: Szymon Kłos <szymon.klos@collabora.com> Change-Id: I0eb434b4d1ed9e4ec4eb9c463d0aa4516e0926d5
eszkadev
force-pushed
the
private/eszkadev/server-audit-dialog-master
branch
from
fc0f8c3
to
c24559f
Compare
append "," when needed Signed-off-by: Szymon Kłos <szymon.klos@collabora.com> Change-Id: Ic5147ec34ea47521e18687e0ed408bf902962768
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com> Change-Id: I99e5bf9b07effd8c84c3f716e98700874c0804c1
caolanm
approved these changes
Jun 4, 2024
This will allow to avoid parallel access from many sources. If one instance is used by different integrations - we will warn only affected users. Signed-off-by: Szymon Kłos <szymon.klos@collabora.com> Change-Id: Ic397566c8e8e699dbfe5fd60b305040f735b44bc
eszkadev
force-pushed
the
private/eszkadev/server-audit-dialog-master
branch
from
0d20d50
to
2e0582e
Compare
|
great, much more reassuring :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.