ServerAudit: use IsAdminUser property #9242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eszkadev
force-pushed
the
private/eszkadev/server-audit-improvements
branch
2 times, most recently
from
abd0650
to
3ebd827
Compare
eszkadev
added a commit
to eszkadev/richdocuments
that referenced
this pull request
Jun 10, 2024
is_admin field inside UserExtraInfo is deprecated now. We use dedicated IsAdminUser property in CheckFileInfo instead. Leave old code for now for backward compatibility. see: CollaboraOnline/online#9242 Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
eszkadev
force-pushed
the
private/eszkadev/server-audit-improvements
branch
4 times, most recently
from
72ed0c0
to
5861786
Compare
eszkadev
added a commit
to eszkadev/richdocuments
that referenced
this pull request
Jun 11, 2024
is_admin field inside UserExtraInfo is deprecated now. We use dedicated IsAdminUser property in CheckFileInfo instead. Leave old code for now for backward compatibility. see: CollaboraOnline/online#9242 Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
timar
reviewed
Jun 11, 2024
eszkadev
force-pushed
the
private/eszkadev/server-audit-improvements
branch
from
5861786
to
b943b83
Compare
and set old is_admin inside UserExtraInfo as deprecated Signed-off-by: Szymon Kłos <szymon.klos@collabora.com> Change-Id: Id6287798346c29e04adcf5c780c442e1edb8962a
- use app.isAdminUser for storing it - use adminuser: message to pass it from the server which is sent before serveraudit: and after viewinfo: - do not send server audit on every user joined and on document unload Signed-off-by: Szymon Kłos <szymon.klos@collabora.com> Change-Id: I993f34fc35d621bb83ead12f245541acdcb292a5
eszkadev
force-pushed
the
private/eszkadev/server-audit-improvements
branch
from
b943b83
to
6f273d3
Compare
|
it also fixes random failures in cpp tests caused by commit 1a0d289 |
backportbot bot
pushed a commit
to nextcloud/richdocuments
that referenced
this pull request
Jun 12, 2024
is_admin field inside UserExtraInfo is deprecated now. We use dedicated IsAdminUser property in CheckFileInfo instead. Leave old code for now for backward compatibility. see: CollaboraOnline/online#9242 Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
backportbot bot
pushed a commit
to nextcloud/richdocuments
that referenced
this pull request
Jun 12, 2024
is_admin field inside UserExtraInfo is deprecated now. We use dedicated IsAdminUser property in CheckFileInfo instead. Leave old code for now for backward compatibility. see: CollaboraOnline/online#9242 Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
backportbot bot
pushed a commit
to nextcloud/richdocuments
that referenced
this pull request
Jun 12, 2024
is_admin field inside UserExtraInfo is deprecated now. We use dedicated IsAdminUser property in CheckFileInfo instead. Leave old code for now for backward compatibility. see: CollaboraOnline/online#9242 Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and set old is_admin inside UserExtraInfo as deprecated
TODO: SDK update so links will point to the content