Update Bootstrap: CellLine Details #2059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beque
reviewed
Aug 7, 2024
| <Button | ||
| disabled={readOnly} | ||
| size="sm" | ||
| className="" |
There was a problem hiding this comment.
What happens when you remove className="" ?
Is it necessary?
| </Panel> | ||
| ); | ||
| } | ||
| export default function EditModeRow({ |
There was a problem hiding this comment.
If you change this to a functional component.
Prefer to write it like this:
export default EditModeRow = ({ container, parent, element, readOnly }) => {
or you can write it like this:
const default EditModeRow = ({ container, parent, element, readOnly }) => {
and the export default EditModeRow at the end of the file
Also consolidate EditModeHeader and OrderModeHeader into a single Header component.
maiwald
force-pushed
the
update-bootstrap-cellline-details
branch
from
61ea287
to
e4e53f9
Compare
ashwiniHerle
pushed a commit
that referenced
this pull request
Aug 13, 2024
* Remove unused method in CellLineDetails * Update CellLineDetails to new bootstrap version * Change cell line GeneralProperties PanelGroup to Accordion * Translate Form in GeneralProperties and CellLineName * Use utility classes in InvalidPropertyWarning * Use utility classes for Amount, separate logic and markup * Update AnalysesContainer button placement to utility classes * Update AnalysesContainer to new bootstrap version Also consolidate EditModeHeader and OrderModeHeader into a single Header component. * Remove unused css rule * Translate custom css to utility class * Style analysesTab Header using utility classes
maiwald
added a commit
that referenced
this pull request
Aug 27, 2024
* Remove unused method in CellLineDetails * Update CellLineDetails to new bootstrap version * Change cell line GeneralProperties PanelGroup to Accordion * Translate Form in GeneralProperties and CellLineName * Use utility classes in InvalidPropertyWarning * Use utility classes for Amount, separate logic and markup * Update AnalysesContainer button placement to utility classes * Update AnalysesContainer to new bootstrap version Also consolidate EditModeHeader and OrderModeHeader into a single Header component. * Remove unused css rule * Translate custom css to utility class * Style analysesTab Header using utility classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.