Bootstrap upgrade bugfixes 2 #2189
Conversation
| <div className="tabs-container--with-borders"> | ||
| <div | ||
| // className="tabs-container--with-borders" | ||
| > |
There was a problem hiding this comment.
Should this class be removed?
| <ReactionDetailsContainers | ||
| reaction={reaction} | ||
| readOnly={!permitOn(reaction)} | ||
| handleSubmit={this.handleSubmit} | ||
| handleReactionChange={this.handleReactionChange} | ||
| /> | ||
| </ListGroupItem> | ||
| {/* </ListGroupItem> */} | ||
| </Tab> |
There was a problem hiding this comment.
Can the ListGroupItem be removed?
| @@ -352,56 +351,72 @@ export default class ReactionDetailsContainers extends Component { | |||
| )); | |||
|
|
|||
| if (analyses_container.length === 1 && analyses_container[0].children.length > 0) { | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Minimum one empty line too much
There was a problem hiding this comment.
Button in Analyses Header have no gap
| {analysesContainer[0].children.map((container, key) => { | ||
| if (container.is_deleted) { | ||
| return ( | ||
| <Accordion.Item | ||
| eventKey={key} | ||
| key={`research_plan_container_deleted_${container.id}`} | ||
| className="border rounded overflow-hidden" |
There was a problem hiding this comment.
The border is too big. Maybe border rounded is not necessary here
There was a problem hiding this comment.
Buttons in Analyses Header have no gap
|
Have made necessary changes based on feedback and also fixed few undefined errors in cellLines. |
ashwiniHerle
force-pushed
the
bootstrap-upgrade-bugfixes-2
branch
from
468f005
to
ae9d55d
Compare
| /> | ||
| </Accordion.Body> | ||
| </Accordion.Item> | ||
| <Card eventKey={container.id}> |
There was a problem hiding this comment.
There is a double border around the analyses header.
If you add border-0 at <Card> it should look good
Other analyses have the classes border-0 rounded-0
| return ( | ||
| <Accordion.Item | ||
| <Card | ||
| eventKey={key} | ||
| key={`research_plan_container_${container.id}`} | ||
| > |
There was a problem hiding this comment.
Adding class border-0 removes double border
Other analyses have the classes border-0 rounded-0
| @@ -3,16 +3,16 @@ import { observer } from 'mobx-react'; | |||
| import { Button, Badge } from 'react-bootstrap'; | |||
| import { StoreContext } from 'src/stores/mobx/RootStore'; | |||
|
|
|||
| const SampleTaskNavigationElement = ({}) => { | |||
| function SampleTaskNavigationElement() { | |||
There was a problem hiding this comment.
Why have you changed this?
const SampleTaskNavigationElement = ({}) => is correct
There was a problem hiding this comment.
There were linting errors. I'll undo it
Minor styling fixes related to bootstrap upgrade.
Made analyses look similar throughout samples, reactions and researchplans, wellplates and cellLines
Fix for issue where contextActions buttons vertically expanded in smaller screens
Show notification message numbers on NoticeButton