Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix psu status metric and large fw scrape time #86

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Fix psu status metric and large fw scrape time #86

merged 2 commits into from
Jul 10, 2024

Conversation

ibrahimkk-moideen
Copy link
Collaborator

a01680e

  • Capture PSU bay number at start to avoid duplicate entry.
  • Ignore PSU status if not installed or absent.

ce2c30f

  • To avoid higher scrape time, limit firmware metric collection if the count of firmware endpoints are less than 75.

This was referenced Jul 9, 2024
Open
Closed
derrick-dacosta
derrick-dacosta approved these changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@derrick-dacosta derrick-dacosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derrick-dacosta
Copy link
Collaborator

@ibrahimkk-moideen Please link issues to PRs

@ibrahimkk-moideen ibrahimkk-moideen linked an issue Jul 10, 2024 that may be closed by this pull request
PowerSupply duplicate metrics #85
Closed
@ibrahimkk-moideen ibrahimkk-moideen merged commit 9264c5b into main Jul 10, 2024
3 checks passed
@ibrahimkk-moideen ibrahimkk-moideen deleted the fix_psu_status_metric branch July 10, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrick-dacosta derrick-dacosta derrick-dacosta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PowerSupply duplicate metrics
2 participants
@ibrahimkk-moideen @derrick-dacosta