Évite toujours le cache lorsque l'on récupère les créneaux #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhumblot
approved these changes
May 17, 2021
fcamblor
reviewed
May 17, 2021
| this._lieuxParDepartement.set(codeDepartement, lieuxParDepartement); | ||
| return lieuxParDepartement; | ||
| } | ||
| async lieuxPour(codeDepartement: CodeDepartement): Promise<LieuxParDepartement> { |
There was a problem hiding this comment.
@Floby Je suis pas ultra fan de la suppression de la memoization, car dès qu'on change un simple critère (comme le critère de tri) on se reprend N requêtes département
Pour moi, le but du bouton "Rafraîchir" était là justement pour pallier à cette problématique : le job en background (destiné à détecter une mise à jour) faisait fi du cache, mais tout le reste se reposait dessus.
|
arf @bilelz a été trop rapide pour moi :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cette PR enlève toute la mécanique de mémoization et ajoute toujours l'option
cache: 'no-cache'lorsque l'on récupère les données de rendez-vous afin d'avoir à coup sûr la donnée la plus fraiche, même après un rafraichissement complet de la page (ce qui est en général le but de la manip).